You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tapestry.apache.org by dtrebbien <dt...@gmail.com> on 2007/07/13 17:24:45 UTC
T5: Should "contribute...()" be "configure...()" or
"configure...Service()"?
I have been creating a small Tapestry 5 application in order to see how the
framework works and how T5 applications differ from JSP/Servlet
applications.
One thing that I did as part of this project was to create an ObjectProvider
implementation (it is very simple, I admit) which allows one to @Inject
http://db4o.com Db4o ObjectServers (after the app's module builder has
added it to MasterObjectProvider).
I would like to suggest that the "contribute...()" methods be renamed to
"configure...()" because the current names are confusing. For example,
contributeMasterObjectProvider does not actually contribute a
MasterObjectProvider; instead, the method is used to add ObjectProviders,
which essentially means configuring the MasterObjectProvider service. Maybe
the method should even be called "configureMasterObjectProviderService" in
order to clarify this even further.
Hopefully other users will comment on this informal proposal as it would be
a somewhat complicated change due to its use almost everywhere.
--
View this message in context: http://www.nabble.com/T5%3A-Should-%22contribute...%28%29%22-be-%22configure...%28%29%22-or-%22configure...Service%28%29%22--tf4075108.html#a11581727
Sent from the Tapestry - User mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: T5: Should "contribute...()" be "configure...()" or
"configure...Service()"?
Posted by dtrebbien <dt...@gmail.com>.
I think that it is fine to call additions to Configurations "contributions",
but then instead of the add() method of Configuration being called "add",
shouldn't it be called "contribute"? This way the code reads as
"contributing to" Configurations.
In terms of Java code conventions
Howard Lewis Ship wrote:
>
> It's alpha, so such changes are still acceptible.
>
> However, you are passed a Configuration, to which you make Contributions.
>
> So it's "contribute TO MasterObjectProvider's Configuration".
>
> On 7/13/07, dtrebbien <dt...@gmail.com> wrote:
>>
>> I have been creating a small Tapestry 5 application in order to see how
>> the
>> framework works and how T5 applications differ from JSP/Servlet
>> applications.
>>
>> One thing that I did as part of this project was to create an
>> ObjectProvider
>> implementation (it is very simple, I admit) which allows one to @Inject
>> http://db4o.com Db4o ObjectServers (after the app's module builder has
>> added it to MasterObjectProvider).
>>
>> I would like to suggest that the "contribute...()" methods be renamed to
>> "configure...()" because the current names are confusing. For example,
>> contributeMasterObjectProvider does not actually contribute a
>> MasterObjectProvider; instead, the method is used to add ObjectProviders,
>> which essentially means configuring the MasterObjectProvider service.
>> Maybe
>> the method should even be called "configureMasterObjectProviderService"
>> in
>> order to clarify this even further.
>>
>> Hopefully other users will comment on this informal proposal as it would
>> be
>> a somewhat complicated change due to its use almost everywhere.
>> --
>> View this message in context:
>> http://www.nabble.com/T5%3A-Should-%22contribute...%28%29%22-be-%22configure...%28%29%22-or-%22configure...Service%28%29%22--tf4075108.html#a11581727
>> Sent from the Tapestry - User mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: users-help@tapestry.apache.org
>>
>>
>
>
> --
> Howard M. Lewis Ship
> TWD Consulting, Inc.
> Independent J2EE / Open-Source Java Consultant
> Creator and PMC Chair, Apache Tapestry
> Creator, Apache HiveMind
>
> Professional Tapestry training, mentoring, support
> and project work. http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/T5%3A-Should-%22contribute...%28%29%22-be-%22configure...%28%29%22-or-%22configure...Service%28%29%22--tf4075108.html#a11630364
Sent from the Tapestry - User mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: T5: Should "contribute...()" be "configure...()" or
"configure...Service()"?
Posted by dtrebbien <dt...@gmail.com>.
I think that it is fine to call additions to Configurations "contributions",
but then instead of the add() method of Configuration being called "add",
shouldn't it be called "contribute"? This way the code reads as
"contributing to" Configurations.
Howard Lewis Ship wrote:
>
> It's alpha, so such changes are still acceptible.
>
> However, you are passed a Configuration, to which you make Contributions.
>
> So it's "contribute TO MasterObjectProvider's Configuration".
>
> On 7/13/07, dtrebbien <dt...@gmail.com> wrote:
>>
>> I have been creating a small Tapestry 5 application in order to see how
>> the
>> framework works and how T5 applications differ from JSP/Servlet
>> applications.
>>
>> One thing that I did as part of this project was to create an
>> ObjectProvider
>> implementation (it is very simple, I admit) which allows one to @Inject
>> http://db4o.com Db4o ObjectServers (after the app's module builder has
>> added it to MasterObjectProvider).
>>
>> I would like to suggest that the "contribute...()" methods be renamed to
>> "configure...()" because the current names are confusing. For example,
>> contributeMasterObjectProvider does not actually contribute a
>> MasterObjectProvider; instead, the method is used to add ObjectProviders,
>> which essentially means configuring the MasterObjectProvider service.
>> Maybe
>> the method should even be called "configureMasterObjectProviderService"
>> in
>> order to clarify this even further.
>>
>> Hopefully other users will comment on this informal proposal as it would
>> be
>> a somewhat complicated change due to its use almost everywhere.
>> --
>> View this message in context:
>> http://www.nabble.com/T5%3A-Should-%22contribute...%28%29%22-be-%22configure...%28%29%22-or-%22configure...Service%28%29%22--tf4075108.html#a11581727
>> Sent from the Tapestry - User mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: users-help@tapestry.apache.org
>>
>>
>
>
> --
> Howard M. Lewis Ship
> TWD Consulting, Inc.
> Independent J2EE / Open-Source Java Consultant
> Creator and PMC Chair, Apache Tapestry
> Creator, Apache HiveMind
>
> Professional Tapestry training, mentoring, support
> and project work. http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/T5%3A-Should-%22contribute...%28%29%22-be-%22configure...%28%29%22-or-%22configure...Service%28%29%22--tf4075108.html#a11630364
Sent from the Tapestry - User mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org
Re: T5: Should "contribute...()" be "configure...()" or "configure...Service()"?
Posted by Howard Lewis Ship <hl...@gmail.com>.
It's alpha, so such changes are still acceptible.
However, you are passed a Configuration, to which you make Contributions.
So it's "contribute TO MasterObjectProvider's Configuration".
On 7/13/07, dtrebbien <dt...@gmail.com> wrote:
>
> I have been creating a small Tapestry 5 application in order to see how the
> framework works and how T5 applications differ from JSP/Servlet
> applications.
>
> One thing that I did as part of this project was to create an ObjectProvider
> implementation (it is very simple, I admit) which allows one to @Inject
> http://db4o.com Db4o ObjectServers (after the app's module builder has
> added it to MasterObjectProvider).
>
> I would like to suggest that the "contribute...()" methods be renamed to
> "configure...()" because the current names are confusing. For example,
> contributeMasterObjectProvider does not actually contribute a
> MasterObjectProvider; instead, the method is used to add ObjectProviders,
> which essentially means configuring the MasterObjectProvider service. Maybe
> the method should even be called "configureMasterObjectProviderService" in
> order to clarify this even further.
>
> Hopefully other users will comment on this informal proposal as it would be
> a somewhat complicated change due to its use almost everywhere.
> --
> View this message in context: http://www.nabble.com/T5%3A-Should-%22contribute...%28%29%22-be-%22configure...%28%29%22-or-%22configure...Service%28%29%22--tf4075108.html#a11581727
> Sent from the Tapestry - User mailing list archive at Nabble.com.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
>
--
Howard M. Lewis Ship
TWD Consulting, Inc.
Independent J2EE / Open-Source Java Consultant
Creator and PMC Chair, Apache Tapestry
Creator, Apache HiveMind
Professional Tapestry training, mentoring, support
and project work. http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org