You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Shilun Fan (Jira)" <ji...@apache.org> on 2024/01/27 02:50:00 UTC

[jira] [Updated] (HDFS-15931) Fix non-static inner classes for better memory management

     [ https://issues.apache.org/jira/browse/HDFS-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shilun Fan updated HDFS-15931:
------------------------------
    Affects Version/s: 3.3.1
                       3.4.0

> Fix non-static inner classes for better memory management
> ---------------------------------------------------------
>
>                 Key: HDFS-15931
>                 URL: https://issues.apache.org/jira/browse/HDFS-15931
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.3.1, 3.4.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.3.1, 3.4.0, 2.10.2, 3.2.3
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> If an inner class does not need to reference its enclosing instance, it can be static. This prevents a common cause of memory leaks and uses less memory per instance of the enclosing class.
> Came across DataNodeProperties as a non static inner class defined in MiniDFSCluster without holding any implicit reference to MiniDFSCluster. Taking this opportunity to find other non-static inner classes that are not holding implicit reference to their respective enclosing instances.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org