You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/03 04:55:25 UTC
[GitHub] [incubator-hudi] satishkotha opened a new pull request #1368:
[HUDI-650] Modify handleUpdate path to validate partitionPath
satishkotha opened a new pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368
## What is the purpose of the pull request
HoodieTable handleUpdate takes in fileId and list of records. It does not validate all records belong to same partitionPath. This is error prone - there is already at least one test that is passing in records that belong to several partitions to this method. Fix to add partitionPath and also validate all records belong to same partition path.
I'm not entirely sure this change is needed though. I think its cleaner to include partition path everywhere. It is a good safeguard, but maybe its unlikely this can happen in production. Sending it out since i already spent some time. I can discard if others think this is unnecessary.
## Brief change log
- Do not assume first record partition can be used for all remaining records
- Track partition path in Bucket and in Partitioner
- Fail updates if they somehow end up in wrong partition
- Fix broken test to validate requests fail
- There is one other test commented out (looks like by mistake). Bring it back
## Verify this pull request
This pull request is already covered by existing tests, such as *(please describe tests)*.
TestCopyOnWriteTable (especially testInsertUpsertWithHoodieAvroPayload)
TestMergeOnReadTable
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395389012
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -295,6 +294,13 @@ private Writer createLogWriter(Option<FileSlice> fileSlice, String baseCommitTim
}
private void writeToBuffer(HoodieRecord<T> record) {
+ if (!partitionPath.equals(record.getPartitionPath())) {
+ writeStatus.markFailure(record, new HoodieUpsertException("mismatched partition path"),
Review comment:
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on issue #1368: [HUDI-650]
Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on issue #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#issuecomment-594188471
> @satishkotha : Can you check if you can do similar refactoring for AppendHandle. Also, unit test is failing. Can you take a look.
Yes, I can look into AppendHandle as well. Just wanted to get opinion on whether this is valuable to spend time on. I'd probably do AppendHandle in a separate PR though to make these easy to review. Let me know if you prefer having one PR.
Regarding unit tests, some unrelated test is failing only in travis (passes locally). I'm re-triggering Travis build. I will fix it soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on issue #1368: [HUDI-650]
Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on issue #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#issuecomment-594772730
@bvaradar updated AppendHandle as well. Please take a look when you can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r393275453
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -61,6 +61,7 @@
private Map<String, HoodieRecord<T>> keyToNewRecords;
private Set<String> writtenRecordKeys;
private HoodieStorageWriter<IndexedRecord> storageWriter;
+ private String partitionPath;
Review comment:
Fixed. I tried to see if there is a way to have this partition validation check in one place, but couldn't find a common entry point. Please let me know if you have suggestions here. happy to refactor more if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r389806772
##########
File path: hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -1208,6 +1207,83 @@ public void testRollingStatsWithSmallFileHandling() throws Exception {
}
}
+ @Test
+ public void testHandleUpdateWithMultiplePartitions() throws Exception {
Review comment:
Can you add descriptive comments at the function level on what this tests and the steps involved ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on issue #1368: [HUDI-650]
Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
bvaradar commented on issue #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#issuecomment-594190980
@satishkotha : It makes sense to do both changes in single PR as they both are closely aligned and part of same refactoring. Please cc me once it is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395389042
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -236,6 +233,10 @@ private boolean writeUpdateRecord(HoodieRecord<T> hoodieRecord, Option<IndexedRe
private boolean writeRecord(HoodieRecord<T> hoodieRecord, Option<IndexedRecord> indexedRecord) {
Option recordMetadata = hoodieRecord.getData().getMetadata();
+ if (!partitionPath.equals(hoodieRecord.getPartitionPath())) {
+ writeStatus.markFailure(hoodieRecord, new HoodieUpsertException("mismatched partition path"), recordMetadata);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r389807896
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -61,6 +61,7 @@
private Map<String, HoodieRecord<T>> keyToNewRecords;
private Set<String> writtenRecordKeys;
private HoodieStorageWriter<IndexedRecord> storageWriter;
+ private String partitionPath;
Review comment:
Now that all handles have partitionPath, can this be moved to base class (HoodieWriteHandle ?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] smarthi commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
smarthi commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r392732290
##########
File path: hudi-client/src/test/java/org/apache/hudi/table/TestCopyOnWriteTable.java
##########
@@ -209,8 +207,8 @@ public void testUpdateRecords() throws Exception {
metaClient = HoodieTableMetaClient.reload(metaClient);
final HoodieCopyOnWriteTable newTable = new HoodieCopyOnWriteTable(config, jsc);
List<WriteStatus> statuses = jsc.parallelize(Arrays.asList(1)).map(x -> {
- return newTable.handleUpdate(newCommitTime, updatedRecord1.getCurrentLocation().getFileId(),
- updatedRecords.iterator());
+ return newTable.handleUpdate(newCommitTime, updatedRecord1.getPartitionPath(),
+ updatedRecord1.getCurrentLocation().getFileId(), updatedRecords.iterator());
Review comment:
nitpick: delete 4 spaces in front.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395228837
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -295,6 +294,13 @@ private Writer createLogWriter(Option<FileSlice> fileSlice, String baseCommitTim
}
private void writeToBuffer(HoodieRecord<T> record) {
+ if (!partitionPath.equals(record.getPartitionPath())) {
+ writeStatus.markFailure(record, new HoodieUpsertException("mismatched partition path"),
Review comment:
Can you add what the expected and actual partition path was in the exception message ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395229769
##########
File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -236,6 +233,10 @@ private boolean writeUpdateRecord(HoodieRecord<T> hoodieRecord, Option<IndexedRe
private boolean writeRecord(HoodieRecord<T> hoodieRecord, Option<IndexedRecord> indexedRecord) {
Option recordMetadata = hoodieRecord.getData().getMetadata();
+ if (!partitionPath.equals(hoodieRecord.getPartitionPath())) {
+ writeStatus.markFailure(hoodieRecord, new HoodieUpsertException("mismatched partition path"), recordMetadata);
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r389807121
##########
File path: hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -1208,6 +1207,83 @@ public void testRollingStatsWithSmallFileHandling() throws Exception {
}
}
+ @Test
+ public void testHandleUpdateWithMultiplePartitions() throws Exception {
+ HoodieWriteConfig cfg = getConfig(true);
+ try (HoodieWriteClient client = getWriteClient(cfg);) {
+
+ /**
+ * Write 1 (only inserts, written as parquet file)
+ */
+ String newCommitTime = "001";
+ client.startCommitWithTime(newCommitTime);
+
+ List<HoodieRecord> records = dataGen.generateInserts(newCommitTime, 20);
+ JavaRDD<HoodieRecord> writeRecords = jsc.parallelize(records, 1);
+
+ List<WriteStatus> statuses = client.upsert(writeRecords, newCommitTime).collect();
+ assertNoWriteErrors(statuses);
+
+ HoodieTableMetaClient metaClient = new HoodieTableMetaClient(jsc.hadoopConfiguration(), cfg.getBasePath());
+ HoodieMergeOnReadTable hoodieTable = (HoodieMergeOnReadTable) HoodieTable.getHoodieTable(metaClient, cfg, jsc);
+
+ Option<HoodieInstant> deltaCommit = metaClient.getActiveTimeline().getDeltaCommitTimeline().firstInstant();
+ assertTrue(deltaCommit.isPresent());
+ assertEquals("Delta commit should be 001", "001", deltaCommit.get().getTimestamp());
+
+ Option<HoodieInstant> commit = metaClient.getActiveTimeline().getCommitTimeline().firstInstant();
+ assertFalse(commit.isPresent());
+
+ FileStatus[] allFiles = HoodieTestUtils.listAllDataFilesInPath(metaClient.getFs(), cfg.getBasePath());
+ BaseFileOnlyView roView =
+ new HoodieTableFileSystemView(metaClient, metaClient.getCommitTimeline().filterCompletedInstants(), allFiles);
+ Stream<HoodieBaseFile> dataFilesToRead = roView.getLatestBaseFiles();
+ assertFalse(dataFilesToRead.findAny().isPresent());
+
+ roView = new HoodieTableFileSystemView(metaClient, hoodieTable.getCompletedCommitsTimeline(), allFiles);
+ dataFilesToRead = roView.getLatestBaseFiles();
+ assertTrue("should list the parquet files we wrote in the delta commit",
+ dataFilesToRead.findAny().isPresent());
+
+ /**
+ * Write 2 (only updates, written to .log file)
+ */
+ newCommitTime = "002";
+ client.startCommitWithTime(newCommitTime);
+
+ records = dataGen.generateUpdates(newCommitTime, records);
+ writeRecords = jsc.parallelize(records, 1);
+ statuses = client.upsert(writeRecords, newCommitTime).collect();
+ assertNoWriteErrors(statuses);
+
+ /**
+ * Write 3 (only deletes, written to .log file)
+ */
+ final String newDeleteTime = "004";
+ final String partitionPath = records.get(0).getPartitionPath();
+ final String fileId = statuses.get(0).getFileId();
+ client.startCommitWithTime(newDeleteTime);
+
+ List<HoodieRecord> fewRecordsForDelete = dataGen.generateDeletesFromExistingRecords(records);
+ JavaRDD<HoodieRecord> deleteRDD = jsc.parallelize(fewRecordsForDelete, 1);
+
+ // initialize partitioner
+ hoodieTable.getUpsertPartitioner(new WorkloadProfile(deleteRDD));
+ final List<List<WriteStatus>> deleteStatus = jsc.parallelize(Arrays.asList(1)).map(x -> {
+ return hoodieTable.handleUpdate(newDeleteTime, partitionPath, fileId, fewRecordsForDelete.iterator());
+ }).map(x -> (List<WriteStatus>) HoodieClientTestUtils.collectStatuses(x)).collect();
+
+ // Verify there are errors
+ WriteStatus status = deleteStatus.get(0).get(0);
+ assertTrue(status.hasErrors());
Review comment:
Can you add comment on why you are expecting errors here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar merged pull request #1368: [HUDI-650]
Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r393275553
##########
File path: hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -1208,6 +1207,83 @@ public void testRollingStatsWithSmallFileHandling() throws Exception {
}
}
+ @Test
+ public void testHandleUpdateWithMultiplePartitions() throws Exception {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on a change in pull request
#1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r393275515
##########
File path: hudi-client/src/test/java/org/apache/hudi/table/TestMergeOnReadTable.java
##########
@@ -1208,6 +1207,83 @@ public void testRollingStatsWithSmallFileHandling() throws Exception {
}
}
+ @Test
+ public void testHandleUpdateWithMultiplePartitions() throws Exception {
+ HoodieWriteConfig cfg = getConfig(true);
+ try (HoodieWriteClient client = getWriteClient(cfg);) {
+
+ /**
+ * Write 1 (only inserts, written as parquet file)
+ */
+ String newCommitTime = "001";
+ client.startCommitWithTime(newCommitTime);
+
+ List<HoodieRecord> records = dataGen.generateInserts(newCommitTime, 20);
+ JavaRDD<HoodieRecord> writeRecords = jsc.parallelize(records, 1);
+
+ List<WriteStatus> statuses = client.upsert(writeRecords, newCommitTime).collect();
+ assertNoWriteErrors(statuses);
+
+ HoodieTableMetaClient metaClient = new HoodieTableMetaClient(jsc.hadoopConfiguration(), cfg.getBasePath());
+ HoodieMergeOnReadTable hoodieTable = (HoodieMergeOnReadTable) HoodieTable.getHoodieTable(metaClient, cfg, jsc);
+
+ Option<HoodieInstant> deltaCommit = metaClient.getActiveTimeline().getDeltaCommitTimeline().firstInstant();
+ assertTrue(deltaCommit.isPresent());
+ assertEquals("Delta commit should be 001", "001", deltaCommit.get().getTimestamp());
+
+ Option<HoodieInstant> commit = metaClient.getActiveTimeline().getCommitTimeline().firstInstant();
+ assertFalse(commit.isPresent());
+
+ FileStatus[] allFiles = HoodieTestUtils.listAllDataFilesInPath(metaClient.getFs(), cfg.getBasePath());
+ BaseFileOnlyView roView =
+ new HoodieTableFileSystemView(metaClient, metaClient.getCommitTimeline().filterCompletedInstants(), allFiles);
+ Stream<HoodieBaseFile> dataFilesToRead = roView.getLatestBaseFiles();
+ assertFalse(dataFilesToRead.findAny().isPresent());
+
+ roView = new HoodieTableFileSystemView(metaClient, hoodieTable.getCompletedCommitsTimeline(), allFiles);
+ dataFilesToRead = roView.getLatestBaseFiles();
+ assertTrue("should list the parquet files we wrote in the delta commit",
+ dataFilesToRead.findAny().isPresent());
+
+ /**
+ * Write 2 (only updates, written to .log file)
+ */
+ newCommitTime = "002";
+ client.startCommitWithTime(newCommitTime);
+
+ records = dataGen.generateUpdates(newCommitTime, records);
+ writeRecords = jsc.parallelize(records, 1);
+ statuses = client.upsert(writeRecords, newCommitTime).collect();
+ assertNoWriteErrors(statuses);
+
+ /**
+ * Write 3 (only deletes, written to .log file)
+ */
+ final String newDeleteTime = "004";
+ final String partitionPath = records.get(0).getPartitionPath();
+ final String fileId = statuses.get(0).getFileId();
+ client.startCommitWithTime(newDeleteTime);
+
+ List<HoodieRecord> fewRecordsForDelete = dataGen.generateDeletesFromExistingRecords(records);
+ JavaRDD<HoodieRecord> deleteRDD = jsc.parallelize(fewRecordsForDelete, 1);
+
+ // initialize partitioner
+ hoodieTable.getUpsertPartitioner(new WorkloadProfile(deleteRDD));
+ final List<List<WriteStatus>> deleteStatus = jsc.parallelize(Arrays.asList(1)).map(x -> {
+ return hoodieTable.handleUpdate(newDeleteTime, partitionPath, fileId, fewRecordsForDelete.iterator());
+ }).map(x -> (List<WriteStatus>) HoodieClientTestUtils.collectStatuses(x)).collect();
+
+ // Verify there are errors
+ WriteStatus status = deleteStatus.get(0).get(0);
+ assertTrue(status.hasErrors());
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on issue #1368: [HUDI-650]
Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on issue #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#issuecomment-599730581
@bvaradar addressed comments, please take another look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] satishkotha commented on issue #1368: [HUDI-650]
Modify handleUpdate path to validate partitionPath
Posted by GitBox <gi...@apache.org>.
satishkotha commented on issue #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#issuecomment-593767854
@bvaradar I briefly talked to you about this earlier today. Please take a look and let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services