You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/06 19:04:37 UTC

[GitHub] [camel-website] AemieJ opened a new pull request #330: Create a sufficient space between the footer-tools and the page

AemieJ opened a new pull request #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330
 
 
   * I observed that the space between the end of a paragraph or any text content and the footer details was too less and it gave a cramped-up feeling in smaller screen width. 
   
   * Hence, the changes I proposed resolves that issue and create sufficient space between the footer-related context and the text-content.
   
   ### BEFORE 
   ![footer-margin-before](https://user-images.githubusercontent.com/44139348/78595347-806fda00-7867-11ea-817f-238e92eb1ebc.png)
   
   ### AFTER
   ![footer-margin-after](https://user-images.githubusercontent.com/44139348/78595358-849bf780-7867-11ea-8c77-80a08feb3426.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610410753
 
 
   > @AemieJ I'm asking because that negative top trick was needed in #307 to have the component/version selection aligned to the bottom. This is with this pull request:
   > 
   > ![Screenshot_2020-04-07 Support for Apache Karaf - Apache Camel(1)](https://user-images.githubusercontent.com/1306050/78678794-b81f6600-78e9-11ea-838d-c576c24f6418.png)
   
   Alright, I will fix that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610125256
 
 
   It exists for all I checked all the blog pages as well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610859488
 
 
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ edited a comment on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610125256
 
 
   It exists for all I checked all the blog pages and various others as well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ edited a comment on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610125256
 
 
   It exists for many pages  including the blog pages and various others as well. This changes makes it neater so it keeps the marginal space consistent for all pages and keeps it sophisticated. You don't want to make it complicated by making separate changes for different pages. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] aashnajena commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
aashnajena commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-609999145
 
 
   Hey, can you please check once if the issue exists for all pages? From what I see, this issue only exists for the front page, probably because of improper padding of the `.split` div. For all other pages, the split seems to have sufficient space. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610527463
 
 
   I came to the conclusion that this issue exists for the front page and most of the blog pages itself. Hence, I have made the following changes for the front page and the blogs only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610407595
 
 
   @AemieJ  I'm asking because that negative top trick was needed in #307 to have the component/version selection aligned to the bottom. This is with this pull request:
   
   ![Screenshot_2020-04-07 Support for Apache Karaf - Apache Camel(1)](https://user-images.githubusercontent.com/1306050/78678794-b81f6600-78e9-11ea-838d-c576c24f6418.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610394104
 
 
   @AemieJ did you check the Antora built pages?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610403009
 
 
   > @AemieJ did you check the Antora built pages?
   
   Yes, I checked the **Antora built pages** and a few of them have the footer and text-content too clustered. Thus, making these changes will maintain consistent spacing and not look clustered for any page.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] AemieJ edited a comment on issue #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on issue #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330#issuecomment-610125256
 
 
   It exists for most I checked the blog pages and various others as well. This changes makes it neater so it keeps the marginal space consistent for all pages and keeps it sophisticated. You don't want to make it complicated by making separate changes for different pages. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart merged pull request #330: Create a sufficient space between the footer-tools and the page

Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #330: Create a sufficient space between the footer-tools and the page
URL: https://github.com/apache/camel-website/pull/330
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services