You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Baike Xia (Code Review)" <ge...@cloudera.org> on 2022/09/05 15:47:51 UTC

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Baike Xia has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18940


Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
11 files changed, 309 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia <xi...@163.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 5:

(8 comments)

Thanks for contributing this!

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/cup/sql-parser.cup@2347
PS5, Line 2347: KW_TBLPROPERTIES LPAREN properties_map:properties RPAREN
nit: can we simplify these to "tbl_properties"?


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java@71
PS5, Line 71:     InlineViewRef inlineViewRef = (InlineViewRef) tableRef;
Does this work for materialized view (MV)? I think we represent MV as tables since IMPALA-10723.


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java@57
PS5, Line 57:   
nit: redudant two spaces.


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@20
PS5, Line 20: import java.util.*;
nit: we avoid using * in imports


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@22
PS5, Line 22: import com.google.common.collect.Maps;
nit: move this to line 33


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@341
PS5, Line 341: tableName
nit: viewName


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1501
PS5, Line 1501:     // IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
nit: don't need this trivial comment


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1511
PS5, Line 1511:         "Could not resolve table reference: 'foo.bar'");
Could you add analyze test for CreateView with tblproperties as well?



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 5
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 13:02:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
13 files changed, 371 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 10
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/views-ddl.test
14 files changed, 441 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/12
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 12
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
12 files changed, 347 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11431/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 07:19:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 12: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 12
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 05:25:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Reviewed-on: http://gerrit.cloudera.org:8080/18940
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M testdata/workloads/functional-query/queries/QueryTest/views-ddl.test
14 files changed, 441 insertions(+), 15 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 14
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18940/9/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:

http://gerrit.cloudera.org:8080/#/c/18940/9/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@546
PS9, Line 546:         "functional", "ALTER VIEW functional.alltypes_view UNSET TBLPROPERTIES ('a', 'c')");
line too long (92 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 06:59:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 13: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 13
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 11:09:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 13:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8623/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 13
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 06:03:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
11 files changed, 310 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 4
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18940/6/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/18940/6/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java@73
PS6, Line 73:           "ALTER VIEW not allowed on a table: %s", tableName_));
This will confuse the user if the view is a materialized view. From the user's perspective, MV is not a table although we treat it as a table internally.

We can check whether 'tableRef' is a MaterializedViewHdfsTable and use another error message, e.g. ALTER VIEW SET TBLPROPERTIES not supported on materialized view.



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 15 Sep 2022 02:36:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 9:

(4 comments)

I made a new fixes. Please help review again.
Thanks.

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java:

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@90
PS7, Line 90:     sb.append(" AS " + viewDefStmt_.toSql(options));
> It seems we won't go here since AlterViewSetTblProperties extends AlterTabl
Yeah this is redundant.


http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@93
PS7, Line 93: }
> If we do need to change this method, I think we should ignore the AS clause
Done


http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java:

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@80
PS7, Line 80: tblPropertyMap
> nit: rename to tblPropertyMap_
OK. I got it.


http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@509
PS7, Line 509:       "default",
> Could you add some tests here? We are lack of test coverage on the toSql() 
OK, I'm going to add.



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 07:04:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 13: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8622/


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 13
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 10:37:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 11:

Thanks for updating the patch quickly!
Sorry that I still have one more comment. I just realized that we are lack of end to end tests to make sure the DDL is executed correctly throught HMS. Currently we just have FE unit tests.

Could you add some end-to-end tests, e.g. in testdata/workloads/functional-query/queries/QueryTest/views-ddl.test ?
It's invoked here: https://github.com/apache/impala/blob/10c19b1a5730a898e17cc653be6bd19f0dc3340e/tests/metadata/test_ddl.py#L522

There are some similar tests in test_ddl.py that probably we can reuse, e.g. test_views_describe, test_alter_table, etc. I think basically we just need tests to run Create/Alter View with Set/UnSet tblproperties and then use DESCRIBE FORMATTED to verify the tblproperties.

You can use the following command to run a single e2e test:
impala-py.test tests/metadata/test_ddl.py::TestDdlStatements::test_views_ddl
ref: https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests#Howtoload,run,andcreatenewImpalatests-Runmostend-to-endtests(butnotcustomclustertests)


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 11
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 00:58:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8608/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 07:05:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 13:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8622/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 13
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 05:26:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11291/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 4
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 16:40:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
11 files changed, 313 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 5
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8616/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 10
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 16:29:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8571/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 08:14:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 7:

> Patch Set 6:
> 
> (1 comment)

Yes, you are right. I've fixed it.
Please review again.
Thanks.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 11:43:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8580/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 11:40:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8529/


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 20:31:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8529/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 15:49:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java:

http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@78
PS10, Line 78:   protected List<ColumnDef> finalColDefs_;  
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:

http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@546
PS10, Line 546:         "functional", "ALTER VIEW functional.alltypes_view UNSET TBLPROPERTIES ('a', 'c')");
line too long (92 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 10
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 16:29:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
13 files changed, 372 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 9: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8608/


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 11:49:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 6:

(7 comments)

Hi all,
I have repaired it, and it is ready for review.
Thanks.

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/cup/sql-parser.cup@2347
PS5, Line 2347: tbl_properties:tbl_props
> nit: can we simplify these to "tbl_properties"?
Yes, this is right.


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java@71
PS5, Line 71:     if (!(tableRef instanceof InlineViewRef)) {
> Does this work for materialized view (MV)? I think we represent MV as table
Yeah, not supposed to work. In the new submission, I added a judgment, and throw exception if it was not InlineViewRef. Like you said, we represent MV as tables, so, will also throw exception.


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@20
PS5, Line 20: import java.util.ArrayList;
> nit: we avoid using * in imports
Got


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@22
PS5, Line 22: import java.util.List;
> nit: move this to line 33
Got


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@341
PS5, Line 341: viewName 
> nit: viewName
Got


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1501
PS5, Line 1501:     AnalyzesOk("ALTER VIEW functional.alltypes_view SET TBLPROPERTIES " +
> nit: don't need this trivial comment
Got


http://gerrit.cloudera.org:8080/#/c/18940/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1511
PS5, Line 1511:     AnalysisError("alter view functional_orc_def.mv1_alltypes_jointbl " +
> Could you add analyze test for CreateView with tblproperties as well?
Got



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 15:29:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
12 files changed, 334 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8569/


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 07:49:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 13:00:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Baike Xia (Code Review)" <ge...@cloudera.org>.
Baike Xia has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................

IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Add TBLPROPERTIES support to the view, here are some examples:
  CREATE VIEW [IF NOT EXISTS] [database_name.]view_name
    [(column_name [COMMENT 'column_comment'][, ...])]
    [COMMENT 'view_comment']
    [TBLPROPERTIES (property_name = property_value, ...)]
    AS select_statement;

  ALTER VIEW [database_name.]view_name SET TBLPROPERTIES
    (property_name = property_value, ...);

  ALTER VIEW [database_name.]view_name UNSET TBLPROPERTIES
    (property_name, ...);

Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
13 files changed, 372 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/18940/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 11
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 13: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 13
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 05:26:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11301/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 5
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 12:52:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 7:

(4 comments)

I only have some comments on the toSql() stuffs. Other changes look good to me.

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java:

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@90
PS7, Line 90:     if (tblPropertyMap != null && !tblPropertyMap.isEmpty()) {
It seems we won't go here since AlterViewSetTblProperties extends AlterTableSetStmt instead of AlterViewStmt. Or did I missing something?


http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@93
PS7, Line 93:     sb.append(" AS " + viewDefStmt_.toSql(options));
If we do need to change this method, I think we should ignore the AS clause when the SET/UNSET clause exists.


http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java:

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@80
PS7, Line 80: tblPropertyMap
nit: rename to tblPropertyMap_

We use the "_" suffix for class fields in our code style.


http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java:

http://gerrit.cloudera.org:8080/#/c/18940/7/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@509
PS7, Line 509:   public void TestAlterView() throws AnalysisException{
Could you add some tests here? We are lack of test coverage on the toSql() methods of "alter view set/unset tblproperties" statements.



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 03:11:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11445/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 11
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 17:00:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11350/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 03:25:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 9:

> Patch Set 9: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8608/

The failure is https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6370
It's due to a flaky test: IMPALA-11508


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 12:32:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11449/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 12
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 04:12:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11368/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 12:01:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11444/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 10
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 16:50:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 10
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 21:20:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 9: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18940/9/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java:

http://gerrit.cloudera.org:8080/#/c/18940/9/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@79
PS9, Line 79: View's tblproperties, and 'key=value''s map.
nit: it seems verbose to me. 'tblPropertyMap_' is clear (by its name) and is set in the constructor. I think we can move it to line 50 and don't need this comment.


http://gerrit.cloudera.org:8080/#/c/18940/9/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@207
PS9, Line 207: Maps.newHashMap
I think we don't need to clone the map. Is there somewhere we modify it? We use the map directly in AlterTableSetTblProperties#toThrift():
https://github.com/apache/impala/blob/9cd4823aa9b940c6e57abbb0c116fb4582cce80a/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java#L83


http://gerrit.cloudera.org:8080/#/c/18940/9/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@243
PS9, Line 243: Maps.newHashMap()
nit: Collections.emptyMap() is slightly better since it won't create a new object.



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Sep 2022 12:49:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18940/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18940/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5282
PS3, Line 5282:             "partition " + partition.getPartitionName(), ALTER_TBL_UNSET_NON_EXIST_PROPERTY);
line too long (93 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 15:48:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 16:24:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8569/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 6
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 03:05:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )

Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11290/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18
Gerrit-Change-Number: 18940
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia <xi...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Sep 2022 16:08:54 +0000
Gerrit-HasComments: No