[GitHub] [cassandra] dcapwell commented on a change in pull request #733: CASSANDRA-15949 Add guardrails to the task that periodically recomputes the global speculative retry threshold.

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #733:
URL: https://github.com/apache/cassandra/pull/733#discussion_r483899636



##########
File path: src/java/org/apache/cassandra/db/Keyspace.java
##########
@@ -337,7 +337,19 @@ private Keyspace(String keyspaceName, boolean loadSSTables)
         for (TableMetadata cfm : metadata.tablesAndViews())
         {
             logger.trace("Initializing {}.{}", getName(), cfm.name);
-            initCf(Schema.instance.getTableMetadataRef(cfm.id), loadSSTables);
+            TableMetadataRef tableMetadataRef = Schema.instance.getTableMetadataRef(cfm.id);

Review comment:
       adding `@Nullable` to this method causes IntelliJ to flag this call site as a warning.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org