You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/19 05:13:05 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #8881: Add layer field to event

wu-sheng commented on code in PR #8881:
URL: https://github.com/apache/skywalking/pull/8881#discussion_r852602048


##########
docs/en/changes/changes.md:
##########
@@ -19,6 +19,7 @@
 * Fix OAP Self-Observability metric `GC Time` calculation.
 * Set `SW_QUERY_MAX_QUERY_COMPLEXITY` default value to `1000`
 * Webapp module (for UI) enabled compression.
+* [Breaking Change] Add layer field to event, report an event without layer will not be allowed.

Review Comment:
   ```suggestion
   * [Breaking Change] Add layer field to event, report an event without layer is be allowed.
   ```
    Future tense in the change log is strange.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org