You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <Ma...@mch.sni.de> on 1997/10/19 23:10:43 UTC
[PATCH] Detect missing at end-of-file
For the directives <Directory>, <DirectoryMatch>, <Location>, <LocationMatch>,
<Files>, <FilesMatch>, <IfModule> and <VirtualHost>, the check if the
block is closed properly at end of file was missing. That can lead to
very confusing behavior, so the patch tries to address this problem with
an error message, preventing apache from starting with an erronous config
file.
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [PATCH] Detect missing at end-of-file
Posted by Dean Gaudet <dg...@arctic.org>.
There's another bug with those directives:
<Directory /foo>
# whatever
</DirectoryMatch>
is valid.
To properly implement these suckers the cmd_params should know about
recursion and know about the end token, and this magic ending message hack
should be ditched.
+1 anyhow.
Dean
On Sun, 19 Oct 1997, Martin Kraemer wrote:
> For the directives <Directory>, <DirectoryMatch>, <Location>, <LocationMatch>,
> <Files>, <FilesMatch>, <IfModule> and <VirtualHost>, the check if the
> block is closed properly at end of file was missing. That can lead to
> very confusing behavior, so the patch tries to address this problem with
> an error message, preventing apache from starting with an erronous config
> file.
>
> Martin
> --
> | S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
> | ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
> | N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
> ~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
>
Re: [PATCH] Detect missing at end-of-file
Posted by Brian Behlendorf <br...@organic.com>.
+1.
At 11:10 PM 10/19/97 +0200, Martin Kraemer wrote:
>For the directives <Directory>, <DirectoryMatch>, <Location>,
<LocationMatch>,
><Files>, <FilesMatch>, <IfModule> and <VirtualHost>, the check if the
>block is closed properly at end of file was missing. That can lead to
>very confusing behavior, so the patch tries to address this problem with
>an error message, preventing apache from starting with an erronous config
>file.
>
> Martin
>--
>| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
>| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
>| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
>~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
>
>Attachment Converted: "c:\eudora\attach\missing.patch"
>
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
"it's a big world, with lots of records to play." - sig brian@organic.com