You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@drill.apache.org by "Jinfeng Ni (JIRA)" <ji...@apache.org> on 2015/06/25 05:18:05 UTC

[jira] [Commented] (DRILL-3366) Short circuit of OR expression causes incorrect partitioning

    [ https://issues.apache.org/jira/browse/DRILL-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600611#comment-14600611 ] 

Jinfeng Ni commented on DRILL-3366:
-----------------------------------

+1. Looks good to me.


> Short circuit of OR expression causes incorrect partitioning
> ------------------------------------------------------------
>
>                 Key: DRILL-3366
>                 URL: https://issues.apache.org/jira/browse/DRILL-3366
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Codegen
>            Reporter: Steven Phillips
>            Assignee: Jinfeng Ni
>         Attachments: DRILL-3366.patch
>
>
> CTAS partitioning relies on evaluating the expression newPartitionValue(column A) || newPartitionValue(column B) || ..
> to determine if there is a new partition should start. The "newPartitionValue" function returns true if the current value of the expression is different from the previous value. The function holds some state in the workspace (the previous value), and thus needs to be evaluated every time. Short circuit expression evaluation causes this to not be the case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)