[jira] [Commented] (OPENNLP-1363) Verify the documentation of the lemmatizer input format

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649338#comment-17649338 ] 

ASF GitHub Bot commented on OPENNLP-1363:
-----------------------------------------

atarora opened a new pull request, #464:
URL: https://github.com/apache/opennlp/pull/464

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   <img width="921" alt="Screenshot 2022-12-19 at 15 00 00" src="https://user-images.githubusercontent.com/5163715/208442890-5dcb6066-2e6d-4ce3-82bf-8b95f96105fa.png">
   




> Verify the documentation of the lemmatizer input format
> -------------------------------------------------------
>
>                 Key: OPENNLP-1363
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1363
>             Project: OpenNLP
>          Issue Type: Documentation
>          Components: Documentation
>    Affects Versions: 2.1.0
>            Reporter: Jeff Zemerick
>            Priority: Minor
>
> In OPENNLP-1257, a change was proposed to update the code to split the lemmatizer input by spaces instead of by tab. I believe tab is the desired delimiter but we need to make sure the documentation is consistent.
> Refer to [https://opennlp.apache.org/docs/1.9.4/manual/opennlp.html#tools.lemmatizer|https://opennlp.apache.org/docs/1.9.4/manual/opennlp.html#tools.lemmatizer.] , in particular the following sentences:
> "The training data consist of three columns separated by spaces. Each word has been put on a separate line and there is an empty line after each sentence. The first column contains the current word, the second its part-of-speech tag and the third its lemma. Here is an example of the file format:"
> Determine if that first line should read "separated by tabs" instead.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)