You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/05 14:06:52 UTC
[GitHub] [trafficcontrol] smalenfant opened a new pull request #5813: Remove STATSSUMMARY from Portal change log
smalenfant opened a new pull request #5813:
URL: https://github.com/apache/trafficcontrol/pull/5813
## What does this PR (Pull Request) do?
This simply removes the nightly STATSSUMMARY entry lines from the Portal change log.
No changelog or test necessary.
## Which Traffic Control components are affected by this PR?
- CDN in a Box
- Traffic Ops
## What is the best way to verify this PR?
Wait until Traffic stats writes the Daily Summary. Should not see any log entries for STATSSUMMARY
## The following criteria are ALL met by this PR
- [ ] This PR includes tests OR I have explained why tests are unnecessary
- [ ] This PR includes documentation OR I have explained why documentation is unnecessary
- [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [X] This PR includes any and all required license headers
- [X] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #5813: Remove STATSSUMMARY from Portal change log
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5813:
URL: https://github.com/apache/trafficcontrol/pull/5813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] smalenfant commented on a change in pull request #5813: Remove STATSSUMMARY from Portal change log
Posted by GitBox <gi...@apache.org>.
smalenfant commented on a change in pull request #5813:
URL: https://github.com/apache/trafficcontrol/pull/5813#discussion_r626648334
##########
File path: traffic_ops/traffic_ops_golang/trafficstats/stats_summary.go
##########
@@ -154,8 +154,8 @@ func CreateStatsSummary(w http.ResponseWriter, r *http.Request) {
}
successMsg := "Stats Summary was successfully created"
- logMsg := fmt.Sprintf("STATSSUMMARY: %v, ID: %v, ACTION: create stats_summary", *ss.StatName, id)
- api.CreateChangeLogRawTx(api.ApiChange, logMsg, inf.User, inf.Tx.Tx)
+ // logMsg := fmt.Sprintf("STATSSUMMARY: %v, ID: %v, ACTION: create stats_summary", *ss.StatName, id)
Review comment:
Thanks. I was just testing and looks like I left this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5813: Remove STATSSUMMARY from Portal change log
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #5813:
URL: https://github.com/apache/trafficcontrol/pull/5813#discussion_r626632238
##########
File path: traffic_ops/traffic_ops_golang/trafficstats/stats_summary.go
##########
@@ -154,8 +154,8 @@ func CreateStatsSummary(w http.ResponseWriter, r *http.Request) {
}
successMsg := "Stats Summary was successfully created"
- logMsg := fmt.Sprintf("STATSSUMMARY: %v, ID: %v, ACTION: create stats_summary", *ss.StatName, id)
- api.CreateChangeLogRawTx(api.ApiChange, logMsg, inf.User, inf.Tx.Tx)
+ // logMsg := fmt.Sprintf("STATSSUMMARY: %v, ID: %v, ACTION: create stats_summary", *ss.StatName, id)
Review comment:
please delete. no need to leave cruft in the code. if this code is needed, easy enough to revert it using git.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] smalenfant commented on pull request #5813: Remove STATSSUMMARY from Portal change log
Posted by GitBox <gi...@apache.org>.
smalenfant commented on pull request #5813:
URL: https://github.com/apache/trafficcontrol/pull/5813#issuecomment-833529577
This worked when merged in 5.1.x. Verified that the changelog doesn't get the STATSSUMMARY entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org