You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/05 16:35:32 UTC
[GitHub] [airflow] potiuk opened a new pull request #7372: [AIRFLOW-6738]
Upload container diagnostics on failure
potiuk opened a new pull request #7372: [AIRFLOW-6738] Upload container diagnostics on failure
URL: https://github.com/apache/airflow/pull/7372
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7372: [AIRFLOW-6738] Upload
container diagnostics always
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7372: [AIRFLOW-6738] Upload container diagnostics always
URL: https://github.com/apache/airflow/pull/7372#issuecomment-582813804
We seem to have again some unstability of travis builds - looks like networking issue. I added this one to get better diagnostics in place - this file.io upload is really useful to see what's going on as we can easily download logs from all containers even if it is quite long. See for example here: https://file.io/rcjDkg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7372: [AIRFLOW-6738] Upload
container diagnostics always
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7372: [AIRFLOW-6738] Upload container diagnostics always
URL: https://github.com/apache/airflow/pull/7372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7372:
[AIRFLOW-6738] Upload container diagnostics on failure
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7372: [AIRFLOW-6738] Upload container diagnostics on failure
URL: https://github.com/apache/airflow/pull/7372#issuecomment-582524422
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=h1) Report
> Merging [#7372](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2195bb45be00f0bdaadf4b7009db40f360f5455b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7372 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 871 871
Lines 40627 40627
=======================================
Hits 35083 35083
Misses 5544 5544
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=footer). Last update [2195bb4...1f147f0](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7372:
[AIRFLOW-6738] Upload container diagnostics always
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7372: [AIRFLOW-6738] Upload container diagnostics always
URL: https://github.com/apache/airflow/pull/7372#issuecomment-582524422
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=h1) Report
> Merging [#7372](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2195bb45be00f0bdaadf4b7009db40f360f5455b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7372 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 871 871
Lines 40627 40627
=======================================
Hits 35083 35083
Misses 5544 5544
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=footer). Last update [2195bb4...75fcc87](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7372: [AIRFLOW-6738]
Upload container diagnostics on failure
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7372: [AIRFLOW-6738] Upload container diagnostics on failure
URL: https://github.com/apache/airflow/pull/7372#issuecomment-582524422
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=h1) Report
> Merging [#7372](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2195bb45be00f0bdaadf4b7009db40f360f5455b?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7372 +/- ##
==========================================
- Coverage 86.35% 86.35% -0.01%
==========================================
Files 871 871
Lines 40627 40627
==========================================
- Hits 35083 35082 -1
- Misses 5544 5545 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7372/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=footer). Last update [2195bb4...3425505](https://codecov.io/gh/apache/airflow/pull/7372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7372: [AIRFLOW-6738] Upload
container diagnostics always
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7372: [AIRFLOW-6738] Upload container diagnostics always
URL: https://github.com/apache/airflow/pull/7372#issuecomment-582872424
> LGTM - This is really useful 👍
>
> However the file you linked does not exist (anymore) - 404. Can we somehow define how long the files will be available or use a different service?
It's 14 days by default. I think I cropped one letter: Here is link from another job (can't remember which one I copied before): https://file.io/vnwGWe
And this is what is written in the logs (at the end so easy to find).:
```
##############################################################################
Logs saved to /tmp/2020-02-06_docker_646670658_646670665.log.gz
##############################################################################
{"success":true,"key":"vnwGWe","link":"https://file.io/vnwGWe","expiry":"14 days"}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services