You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by Sheng Wu <wu...@gmail.com> on 2020/01/10 06:22:29 UTC
Pxx metrics name and query language will be changed in 7.0.0
Hi
I am proposing this new query API[1] for 7.0.0. Once it gets merged, the
following changes will remove the old p50-p99 metrics, like this
service_p99 = from(Service.latency).p99(10);
service_p95 = from(Service.latency).p95(10);
service_p90 = from(Service.latency).p90(10);
service_p75 = from(Service.latency).p75(10);
service_p50 = from(Service.latency).p50(10);
And relaced by
> service_pertentile = from(Service.latency).percentile(50,75,90,95,99)
Query side will use `service_pertentile` as metrics with the new API to get
full values.
Zhenxu Ke
Could you submit an issue of CLI to track this? Because p50 will not be
queryable from the old API anymore.
[1] https://github.com/apache/skywalking-query-protocol/pull/28
Sheng Wu 吴晟
Twitter, wusheng1108
Re: Pxx metrics name and query language will be changed in 7.0.0
Posted by Sheng Wu <wu...@gmail.com>.
Yes, one index, and one record for all these.
I will work on new percentile func in OAL implementation after the PR gets
merged :)
I think this would be helpful for performance, and customized extension for
sure.
Sheng Wu 吴晟
Twitter, wusheng1108
Jian Tan <ta...@apache.org> 于2020年1月10日周五 下午2:25写道：
> Does that mean 50,75,90,95,99's data will record into one index?
>
> Sheng Wu <wu...@gmail.com> 于2020年1月10日周五 下午2:22写道：
>
> > Hi
> >
> > I am proposing this new query API[1] for 7.0.0. Once it gets merged, the
> > following changes will remove the old p50-p99 metrics, like this
> >
> > service_p99 = from(Service.latency).p99(10);
> > service_p95 = from(Service.latency).p95(10);
> > service_p90 = from(Service.latency).p90(10);
> > service_p75 = from(Service.latency).p75(10);
> > service_p50 = from(Service.latency).p50(10);
> >
> > And relaced by
> > > service_pertentile = from(Service.latency).percentile(50,75,90,95,99)
> >
> > Query side will use `service_pertentile` as metrics with the new API to
> get
> > full values.
> >
> > Zhenxu Ke
> > Could you submit an issue of CLI to track this? Because p50 will not be
> > queryable from the old API anymore.
> >
> > [1] https://github.com/apache/skywalking-query-protocol/pull/28
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
>
>
> --
> Jian Tan
> Apache SkyWalking Committer && PMC, DaoCloud Labs
> Twitter, @tanjian2015
>
Re: Pxx metrics name and query language will be changed in 7.0.0
Posted by Sheng Wu <wu...@gmail.com>.
Hi Qiuxia
The feature has been done and deployed on the demo environment. You could
follow the UI changes.
Sheng Wu 吴晟
Twitter, wusheng1108
Jian Tan <ta...@apache.org> 于2020年1月10日周五 下午2:27写道：
> Got it.
>
> > This new query will be suitable for query all p50-99 once. Also, reduce
> the backend payload and number of index.
>
> Jian Tan <ta...@apache.org> 于2020年1月10日周五 下午2:25写道：
>
> > Does that mean 50,75,90,95,99's data will record into one index?
> >
> > Sheng Wu <wu...@gmail.com> 于2020年1月10日周五 下午2:22写道：
> >
> >> Hi
> >>
> >> I am proposing this new query API[1] for 7.0.0. Once it gets merged, the
> >> following changes will remove the old p50-p99 metrics, like this
> >>
> >> service_p99 = from(Service.latency).p99(10);
> >> service_p95 = from(Service.latency).p95(10);
> >> service_p90 = from(Service.latency).p90(10);
> >> service_p75 = from(Service.latency).p75(10);
> >> service_p50 = from(Service.latency).p50(10);
> >>
> >> And relaced by
> >> > service_pertentile = from(Service.latency).percentile(50,75,90,95,99)
> >>
> >> Query side will use `service_pertentile` as metrics with the new API to
> >> get
> >> full values.
> >>
> >> Zhenxu Ke
> >> Could you submit an issue of CLI to track this? Because p50 will not be
> >> queryable from the old API anymore.
> >>
> >> [1] https://github.com/apache/skywalking-query-protocol/pull/28
> >>
> >> Sheng Wu 吴晟
> >> Twitter, wusheng1108
> >>
> >
> >
> > --
> > Jian Tan
> > Apache SkyWalking Committer && PMC, DaoCloud Labs
> > Twitter, @tanjian2015
> >
>
>
> --
> Jian Tan
> Apache SkyWalking Committer && PMC, DaoCloud Labs
> Twitter, @tanjian2015
>
Re: Pxx metrics name and query language will be changed in 7.0.0
Posted by Jian Tan <ta...@apache.org>.
Got it.
> This new query will be suitable for query all p50-99 once. Also, reduce
the backend payload and number of index.
Jian Tan <ta...@apache.org> 于2020年1月10日周五 下午2:25写道：
> Does that mean 50,75,90,95,99's data will record into one index?
>
> Sheng Wu <wu...@gmail.com> 于2020年1月10日周五 下午2:22写道：
>
>> Hi
>>
>> I am proposing this new query API[1] for 7.0.0. Once it gets merged, the
>> following changes will remove the old p50-p99 metrics, like this
>>
>> service_p99 = from(Service.latency).p99(10);
>> service_p95 = from(Service.latency).p95(10);
>> service_p90 = from(Service.latency).p90(10);
>> service_p75 = from(Service.latency).p75(10);
>> service_p50 = from(Service.latency).p50(10);
>>
>> And relaced by
>> > service_pertentile = from(Service.latency).percentile(50,75,90,95,99)
>>
>> Query side will use `service_pertentile` as metrics with the new API to
>> get
>> full values.
>>
>> Zhenxu Ke
>> Could you submit an issue of CLI to track this? Because p50 will not be
>> queryable from the old API anymore.
>>
>> [1] https://github.com/apache/skywalking-query-protocol/pull/28
>>
>> Sheng Wu 吴晟
>> Twitter, wusheng1108
>>
>
>
> --
> Jian Tan
> Apache SkyWalking Committer && PMC, DaoCloud Labs
> Twitter, @tanjian2015
>
--
Jian Tan
Apache SkyWalking Committer && PMC, DaoCloud Labs
Twitter, @tanjian2015
Re: Pxx metrics name and query language will be changed in 7.0.0
Posted by Jian Tan <ta...@apache.org>.
Does that mean 50,75,90,95,99's data will record into one index?
Sheng Wu <wu...@gmail.com> 于2020年1月10日周五 下午2:22写道：
> Hi
>
> I am proposing this new query API[1] for 7.0.0. Once it gets merged, the
> following changes will remove the old p50-p99 metrics, like this
>
> service_p99 = from(Service.latency).p99(10);
> service_p95 = from(Service.latency).p95(10);
> service_p90 = from(Service.latency).p90(10);
> service_p75 = from(Service.latency).p75(10);
> service_p50 = from(Service.latency).p50(10);
>
> And relaced by
> > service_pertentile = from(Service.latency).percentile(50,75,90,95,99)
>
> Query side will use `service_pertentile` as metrics with the new API to get
> full values.
>
> Zhenxu Ke
> Could you submit an issue of CLI to track this? Because p50 will not be
> queryable from the old API anymore.
>
> [1] https://github.com/apache/skywalking-query-protocol/pull/28
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
--
Jian Tan
Apache SkyWalking Committer && PMC, DaoCloud Labs
Twitter, @tanjian2015