[jira] [Commented] (AURORA-1622) Add ability to pass in environment variables into shell health checker

["Dmitriy Shirchenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15160081#comment-15160081 ] 

Dmitriy Shirchenko commented on AURORA-1622:
--------------------------------------------

On second thought, maybe just passing in the assigned port via an environment variable would do it. 

Just need to switch check_call to Popen  here [1] and pass the port from here [2]

[1] https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/common/health_check/shell.py#L50
[2] https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/common/health_checker.py#L224

> Add ability to pass in environment variables into shell health checker
> ----------------------------------------------------------------------
>
>                 Key: AURORA-1622
>                 URL: https://issues.apache.org/jira/browse/AURORA-1622
>             Project: Aurora
>          Issue Type: Task
>            Reporter: Dmitriy Shirchenko
>
> A use case is to execute the health check command based on the port assignment. 
> One of the options is to change subprocess32 to use Popen funciton instead of current check_call as Popen has an env= argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)