You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Roy T. Fielding" <fi...@kiwi.ics.uci.edu> on 1997/07/17 10:51:08 UTC
Re: proxy auth
Seems like an awful lot of changes considering that
if (r->proxyreq && type == AUTH_REQUIRED)
r->status = HTTP_PROXY_AUTHENTICATION_REQUIRED;
else
r->status = type;
in die() does the same thing.
This last part is wrong (consider proxy chaining), but I don't know
where in the proxy it should be setting/clearing these fields.
This part of the proxy is broken anyway.
>***************
>*** 260,266 ****
> for (i=0; i < reqhdrs_arr->nelts; i++)
> {
> if (reqhdrs[i].key == NULL || reqhdrs[i].val == NULL
>! || !strcasecmp(reqhdrs[i].key, "Host")) /* already sent if there */
> continue;
> bvputs(f, reqhdrs[i].key, ": ", reqhdrs[i].val, "\015\012", NULL);
> }
>--- 260,268 ----
> for (i=0; i < reqhdrs_arr->nelts; i++)
> {
> if (reqhdrs[i].key == NULL || reqhdrs[i].val == NULL
>! /* Clear out headers not to send */
>! || !strcasecmp(reqhdrs[i].key, "Host") /* Already sent */
>! || !strcasecmp(reqhdrs[i].key, "Proxy-Authorization"))
> continue;
> bvputs(f, reqhdrs[i].key, ": ", reqhdrs[i].val, "\015\012", NULL);
> }
....Roy