You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/04 03:28:42 UTC

[GitHub] [beam] ihji commented on pull request #12325: [BEAM-10543] Upgrade Kafka cross-language python tests

ihji commented on pull request #12325:
URL: https://github.com/apache/beam/pull/12325#issuecomment-668359113


   Thanks, looks good to me overall.
   
   Is there any way to share the pipeline codes in `CrossLanguageKafkaIOTest` and `CrossLanguageKafkaIO`? Could we share the pipeline codes and use `max_num_records` only in `CrossLanguageKafkaIOTest`? The internal test only checks `sum_counter` so you could keep any value in the `PCollection` afterward and assert it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org