You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/06 11:41:23 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new issue, #17: ensure scala-3 branch ends up with all the changes on main branch
pjfanning opened a new issue, #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17
* `scala-3` branch is basically a fork of `main` branch but with support for Scala3.
* it has been updated with most of the recent commits to `main` (cherry-picked or an equivalent commit if the cherry pick did not work)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1495560840
> Not sure if entirely relevant but Is there a reason why you are using Scala 3.2.1?
parboiled2 is on 3.2.1 so we have to be, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1375554540
> @mdedetrich since you made the https://github.com/apache/incubator-pekko-http/commit/56158e46960d601437fda04a726ed81162bd3b2b changes, would you be a position to do an equivalent change for the 'scala-3' branch so that that branch does not become stale?
Will do, I actually wanted to do one additional PR to change the package to `org.apache.pekko`, since we are starting to have PRs against pekko http I want to reduce merge conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1495581984
Here's a diff to fix the immediate problem:
```diff
diff --git a/http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/CommonRules.scala b/http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/CommonRules.scala
index 49b4e05311..12223e5a12 100644
--- a/http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/CommonRules.scala
+++ b/http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/CommonRules.scala
@@ -22,7 +22,9 @@ import pekko.http.scaladsl.model.headers._
import org.parboiled2._
import org.parboiled2.support.hlist._
-private[parser] trait CommonRules { this: HeaderParser with Parser with StringBuilding =>
+private[parser] trait CommonRules extends StringBuilding { this: Parser =>
+ protected def maxCommentParsingDepth: Int
+
import CharacterClasses._
// ******************************************************************************************
```
Though, there's another minor problem in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1495565652
> This does not really matter right now as Scala 3 is backward compatible but not forward. You can use pekko core with a lower Scala 3 version than pekko-http.
Okay then its unrelated. There is a version of Parboiled that was released for Scala 3.1.1 (version `2.4.0` specifically) but in any case Pekko will very likely get updated to use Scala 3.2.1 as mentioned before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1400046651
Is there a good reason to use cherry picking for that branch? I think we should use merge the main branch back to the scala-3 branch from time to time. Otherwise, the final merge will be a big problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning closed issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #17: ensure scala-3 branch ends up with all the changes on main branch
URL: https://github.com/apache/incubator-pekko-http/issues/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1495586356
I think we can just remove the test failing to compile in HttpHeaderSpec regarding `If-Match` dispatching, it's not relevant any more anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1495562470
> Note that there is a PR that will update Pekko to use Scala 3.2.2 (see [apache/incubator-pekko#273](https://github.com/apache/incubator-pekko/pull/273)) but it hasn't been merged yet.
This does not really matter right now as Scala 3 is backward compatible but not forward. You can use pekko core with a lower Scala 3 version than pekko-http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] raboof commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1494622669
I started on bringing a branch up to date by merging main (in chunks), WIP is at https://github.com/apache/incubator-pekko-http/compare/main...raboof:incubator-pekko-http:scala-3-merged .
I got stuck at merging 26846a02a116993138365405354efc45cb49b563 - perhaps @luksow can spot what goes wrong there (when you build with `sbt ++3.2.1 compile`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1494650969
@raboof Not sure if entirely relevant but Is there a reason why you are using Scala 3.2.1? I was under the impression that for now we are compiling against Scala 3.1.1 since thats what Pekko is built against (see https://github.com/apache/incubator-pekko/blob/main/project/Dependencies.scala#L57). Note that there is a PR that will update Pekko to use Scala 3.2.0 (see https://github.com/apache/incubator-pekko/pull/273) but it hasn't been merged yet.
Will also update assignees
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1400262203
I was imaging a merge as well. I haven't looked into this because of https://github.com/apache/incubator-pekko/issues/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1594667838
https://github.com/apache/incubator-pekko-http/pull/130 is merged to main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #17: ensure scala-3 branch ends up with all the changes on main branch
Posted by GitBox <gi...@apache.org>.
pjfanning commented on issue #17:
URL: https://github.com/apache/incubator-pekko-http/issues/17#issuecomment-1375513559
@mdedetrich since you made the https://github.com/apache/incubator-pekko-http/commit/56158e46960d601437fda04a726ed81162bd3b2b changes, would you be a position to do an equivalent change for the 'scala-3' branch so that that branch does not become stale?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org