[GitHub] [spark] beliefer commented on a change in pull request #24312: [SQL] Unnecessary access to externalCatalog

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #24312: [SQL] Unnecessary access to externalCatalog
URL: https://github.com/apache/spark/pull/24312#discussion_r272831834
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ##########
 @@ -1105,10 +1105,16 @@ class SessionCatalog(
    * Check if the function with the specified name exists
    */
   def functionExists(name: FunctionIdentifier): Boolean = {
-    val db = formatDatabaseName(name.database.getOrElse(getCurrentDatabase))
 
 Review comment:
   The `db` is not only pass to `externalCatalog.functionExists` but also used to check.
   So I think this change need more thinking.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org