You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/10/06 02:10:04 UTC
[kudu-CR] client: bump scanner log messages to VLOG(2)
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4641
to review the following change.
Change subject: client: bump scanner log messages to VLOG(2)
......................................................................
client: bump scanner log messages to VLOG(2)
We previously logged every scanner batch at VLOG(1) which is excessively
noisy. Changing this improved the performance of Impala queries
significantly when Impala was running with --v=1.
Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
---
M src/kudu/client/client.cc
M src/kudu/client/scanner-internal.cc
2 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/4641/1
--
To view, visit http://gerrit.cloudera.org:8080/4641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] client: bump scanner log messages to VLOG(2)
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: client: bump scanner log messages to VLOG(2)
......................................................................
client: bump scanner log messages to VLOG(2)
We previously logged every scanner batch at VLOG(1) which is excessively
noisy. Changing this improved the performance of Impala queries
significantly when Impala was running with --v=1.
Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
Reviewed-on: http://gerrit.cloudera.org:8080/4641
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/client/scanner-internal.cc
2 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] client: bump scanner log messages to VLOG(2)
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: client: bump scanner log messages to VLOG(2)
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4641/1/src/kudu/client/scanner-internal.cc
File src/kudu/client/scanner-internal.cc:
PS1, Line 361: 1
> Just to double-check: is keeping this at level 1 intentional? I guess yes
yea, I thought it would make sense to keep this one since it's a potential issue, like you said.
--
To view, visit http://gerrit.cloudera.org:8080/4641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] client: bump scanner log messages to VLOG(2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: client: bump scanner log messages to VLOG(2)
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4641/1/src/kudu/client/scanner-internal.cc
File src/kudu/client/scanner-internal.cc:
PS1, Line 361: 1
Just to double-check: is keeping this at level 1 intentional? I guess yes since it's kind of warning-like message.
--
To view, visit http://gerrit.cloudera.org:8080/4641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] client: bump scanner log messages to VLOG(2)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: client: bump scanner log messages to VLOG(2)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No