You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/21 21:35:51 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request #4717: imxrt rename imxrt_lowputc to arm_lowputc and drop CONFIG_DEBUG_FEATURES
davids5 opened a new pull request #4717:
URL: https://github.com/apache/incubator-nuttx/pull/4717
## Summary
Changes from imxrt_lowputc to arm_lowputc were incomplete.
syslog needs up_putc to to call arm_lowputc not dependent on CONFIG_DEBUG_FEATURES
## Impact
master has no console output on hardfault
## Testing
px4 nxp_fmurt1062-v1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #4717: imxrt rename imxrt_lowputc to arm_lowputc and drop CONFIG_DEBUG_FEATURES
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #4717:
URL: https://github.com/apache/incubator-nuttx/pull/4717#issuecomment-949621950
See the naming conventions here: https://cwiki.apache.org/confluence/display/NUTTX/Naming+of+Architecture%2C+MCU%2C+and+Board+Interfaces
Since that is an MCU-specific function, the original name was correct. The proposed renaming is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4717: imxrt rename imxrt_lowputc to arm_lowputc and drop CONFIG_DEBUG_FEATURES
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4717:
URL: https://github.com/apache/incubator-nuttx/pull/4717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4717: imxrt rename imxrt_lowputc to arm_lowputc and drop CONFIG_DEBUG_FEATURES
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4717:
URL: https://github.com/apache/incubator-nuttx/pull/4717#issuecomment-949601928
> Is it good to name the chip specific function with arm_ prefix? It suppose that arm_ is reserved for arm arch common code.
@xiaoxiang781216
No. It is not a good name. I agree with you. However a set of sweeping changes were made at some point. And most all the drivers use arm_ naming now. I would prefer the the root arch prefix (stm32, imxrt) but I do not have the time to fix it all at the moment.
The first commit in this PR just makes it consistent.
Do you want me to drop the 1st commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4717: imxrt rename imxrt_lowputc to arm_lowputc and drop CONFIG_DEBUG_FEATURES
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4717:
URL: https://github.com/apache/incubator-nuttx/pull/4717#issuecomment-949664177
@patacongo - thank you. I have dropped the renaming commit and hopefully fixed the CI issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4717: imxrt rename imxrt_lowputc to arm_lowputc and drop CONFIG_DEBUG_FEATURES
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4717:
URL: https://github.com/apache/incubator-nuttx/pull/4717#issuecomment-949259407
Is it good to name the chip specific function with arm_ prefix? It suppose that arm_ is reserved for arm arch common code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org