You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/27 15:11:13 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #14506: ARROW-16673: [Java] Integrate C Data into allocator hierarchy

lidavidm commented on code in PR #14506:
URL: https://github.com/apache/arrow/pull/14506#discussion_r1007028460


##########
java/c/src/main/java/org/apache/arrow/c/CDataArrayHandle.java:
##########
@@ -0,0 +1,40 @@
+package org.apache.arrow.c;
+
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.arrow.memory.BufferAllocator;
+import org.apache.arrow.memory.ForeignAllocationManager;
+
+/** Manage the reference count of an imported C Data ArrowArray. */

Review Comment:
   There is a fundamental mismatch in memory handling designs and this cannot implement ReferenceManager. I will update the docstring and reconsider the name but I do not think anything else is possible, not without entirely overhauling the core implementation. Even if in theory we can work with only the interfaces provided, in practice we need to fit into the concrete implementations, and so BufferLedger is unavoidable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org