You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dnskr (via GitHub)" <gi...@apache.org> on 2023/04/11 21:06:59 UTC

[GitHub] [airflow] dnskr commented on a diff in pull request #30569: Use template comments for the chart license header

dnskr commented on code in PR #30569:
URL: https://github.com/apache/airflow/pull/30569#discussion_r1163334789


##########
.pre-commit-config.yaml:
##########
@@ -115,8 +115,18 @@ repos:
           - license-templates/LICENSE.txt
           - --fuzzy-match-generates-todo
       - id: insert-license
-        name: Add license for all YAML files
+        name: Add license for all Helm template files
         exclude: ^\.github/.*$|^.*/.*_vendor/

Review Comment:
   1. I've added (leaved) `exclude`, because it's included to all other entries. Agree that it's not needed, I'll delete it.
   
   2. The idea is to apply license to all files in chart/templates folder, for example `chart\templates\NOTES.txt`
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org