You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sunchao (via GitHub)" <gi...@apache.org> on 2023/01/25 19:26:46 UTC
[GitHub] [spark] sunchao commented on a diff in pull request #39746: [SPARK-42188] Force SBT protobuf version to match Maven on branch 3.3
sunchao commented on code in PR #39746:
URL: https://github.com/apache/spark/pull/39746#discussion_r1087082457
##########
project/SparkBuild.scala:
##########
@@ -703,6 +706,8 @@ object KubernetesIntegrationTests {
* Overrides to work around sbt's dependency resolution being different from Maven's.
*/
object DependencyOverrides {
+ import BuildCommons.protoVersion
+
Review Comment:
Missing one line?
```
dependencyOverrides += "com.google.protobuf" % "protobuf-java" % protoVersion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org