You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/28 17:10:46 UTC
[GitHub] [beam] Abacn opened a new pull request, #22081: Followup sharding javaPostCommit
Abacn opened a new pull request, #22081:
URL: https://github.com/apache/beam/pull/22081
Follow up of #21800
* Remove integration test depsOn that already sharded
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169099492
LGTM.
Thanks for the help @Abacn!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169068419
>
Thanks for pinning the context. Then I will update the readme to includes this tests in precommit section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169097726
R: @benWize
R: @fernando-wizeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169064866
> @fernando-wizeline @benWize Jobs created in #21800 and #21804 have file name prefix and templates from `PreCommit`. But should these be `PostCommit` ? Also `.test-infra/jenkins/README.md` needs update
@Abacn here is a discussion about it https://github.com/apache/beam/pull/21808#issuecomment-1157307494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169001292
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169048683
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169001560
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169056060
@fernando-wizeline @benWize Jobs created in #21800 and #21804 have file name prefix and templates from `PreCommit`. But should these be `PostCommit` ? Also `.test-infra/jenkins/README.md` needs update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169103977
LGTM. Thanks, @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169001302
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169048544
postcommit due to `IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry.` Not sure the cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169001290
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169128248
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #22081:
URL: https://github.com/apache/beam/pull/22081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169097064
beam_PreCommit_Java_GCP_IO_Direct links not working yet. Likely need to run seed job. Otherwise ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169001301
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22081: Followup sharding javaPostCommit
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22081:
URL: https://github.com/apache/beam/pull/22081#issuecomment-1169001298
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org