You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2016/11/22 21:44:58 UTC

[jira] [Created] (SLING-6318) Remove repeated retrieval of ValueMap when adapting a model class with multiple ValueMap injections

Justin Edelson created SLING-6318:
-------------------------------------

             Summary: Remove repeated retrieval of ValueMap when adapting a model class with multiple ValueMap injections
                 Key: SLING-6318
                 URL: https://issues.apache.org/jira/browse/SLING-6318
             Project: Sling
          Issue Type: Bug
          Components: Extensions
            Reporter: Justin Edelson
             Fix For: Sling Models Impl 1.3.6


In an offline discussion with [~radu.cotescu], he expressed a concern about how if you have a model class (or interface) with a number of ValueMap-based injections it would end up calling Resource.adaptTo(ValueMap.class) multiple times.

While I think this may be primarily an issue for the Resource implementation to solve for, it is true that the effective code executed by Sling Models is going to be less efficient in this case than manual construction of the object.

So I think it is worth exploring.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)