[GitHub] anirudh2290 commented on a change in pull request #11245: [MXNET-244][MXNET-523][ARM] improvements to ARMv7 based builds.

[GitBox <gi...@apache.org>]

anirudh2290 commented on a change in pull request #11245: [MXNET-244][MXNET-523][ARM] improvements to ARMv7 based builds.
URL: https://github.com/apache/incubator-mxnet/pull/11245#discussion_r195197561
 
 

 ##########
 File path: tests/python/unittest/test_ndarray.py
 ##########
 @@ -711,9 +711,8 @@ def get_values(ensure_unique):
                  k=dat_size*dat_size*dat_size*dat_size, is_ascend=False)
     assert_almost_equal(nd_ret_argsort, gt)
 
-    # test topk with a big shape
-    a = mx.nd.arange(0, 54686454, step=1, repeat=1)
-    assert_almost_equal(a.topk(k=54686454).asnumpy(), a.asnumpy()[::-1])
+    a = mx.nd.arange(0, 1024, step=1, repeat=1)
+    assert_almost_equal(a.topk(k=1024).asnumpy(), a.asnumpy()[::-1])
 
 Review comment:
   since mshadow::range has been fixed to use double instead of float here: https://github.com/dmlc/mshadow/pull/301 , I think it is fine to add the CPP test in the backlog. The risk is that if mshadow::range were to rollback to using float and then mxnet is updated to use that mshadow and some op in mxnet uses mshadow::range this would cause an uncaught bug. I see mshadow::range being used in two ops currently :: bounding_box and grid_generator. This may also change soon since mshadow is being deprecated.  I think the risk is low to justify adding this to backlog.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services