You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/01 10:36:41 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1212: add untyped null
Jimexist opened a new pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-1002576545
I am trying to clean up the list of PRs to review in DataFusion so marking old ones as stale. Please let us know if you plan to work on this soon. Otherwise we will close it down and reopen it when the time is right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957140182
That's a good point @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-1015668560
Closing stale PRs, please reopen if this was a mistake and you plan to keep working on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-988826064
any progress, is there any context or doc for this?
@Jimexist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957287963
> I am not sure anymore this is a good idea.
>
>
>
> The problem with introducing `null` as scalar is that we lose the type information on the scalar (making everything type `Null`). In order to make this work, the value should be converted to an array of the original type afterwards.
The alternative I think is to infer types for null during planning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-958114854
I think that during planning we should treat the type of any `ScalarValue::*(None)` as `DataType::Null` and coerce them appropriately to the needed types as part of physical planning.
@Jimexist I think added the needed casting logic in arrow-rs at https://github.com/apache/arrow-rs/pull/884 (though that didn't make it into 6.1.0 -- so I suppose we have to wait a bit longer -- though maybe I'll end up making a 6.2.0 before 6.1.0 gets through the voting process 🤣 )
Once we can cast from `DataType::Null` I think we'll be able to make this work in DataFusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957287963
> I am not sure anymore this is a good idea.
>
>
>
> The problem with introducing `null` as scalar is that we lose the type information on the scalar (making everything type `Null`). In order to make this work, the value should be converted to an array of the original type afterwards.
The alternative I think is to infer types for null during planning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957287963
> I am not sure anymore this is a good idea.
>
>
>
> The problem with introducing `null` as scalar is that we lose the type information on the scalar (making everything type `Null`). In order to make this work, the value should be converted to an array of the original type afterwards.
The alternative I think is to infer types for null during planning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957140182
That's a good point @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957138939
I am not sure anymore this is a good idea.
The problem with introducing `null` as scalar is that we lose the type information on the scalar (making everything type `Null`). In order to make this work, the value should be converted to an array of the original type afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957140182
That's a good point @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-958114854
I think that during planning we should treat the type of any `ScalarValue::*(None)` as `DataType::Null` and coerce them appropriately to the needed types as part of physical planning.
@Jimexist I think added the needed casting logic in arrow-rs at https://github.com/apache/arrow-rs/pull/884 (though that didn't make it into 6.1.0 -- so I suppose we have to wait a bit longer -- though maybe I'll end up making a 6.2.0 before 6.1.0 gets through the voting process 🤣 )
Once we can cast from `DataType::Null` I think we'll be able to make this work in DataFusio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-958114854
I think that during planning we should treat the type of any `ScalarValue::*(None)` as `DataType::Null` and coerce them appropriately to the needed types as part of physical planning.
@Jimexist I think added the needed casting logic in arrow-rs at https://github.com/apache/arrow-rs/pull/884 (though that didn't make it into 6.1.0 -- so I suppose we have to wait a bit longer -- though maybe I'll end up making a 6.2.0 before 6.1.0 gets through the voting process 🤣 )
Once we can cast from `DataType::Null` I think we'll be able to make this work in DataFusio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957138939
I am not sure anymore this is a good idea.
The problem with introducing `null` as scalar is that we lose the type information on the scalar (making everything type `Null`). In order to make this work, the value should be converted to an array of the original type afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-958114854
I think that during planning we should treat the type of any `ScalarValue::*(None)` as `DataType::Null` and coerce them appropriately to the needed types as part of physical planning.
@Jimexist I think added the needed casting logic in arrow-rs at https://github.com/apache/arrow-rs/pull/884 (though that didn't make it into 6.1.0 -- so I suppose we have to wait a bit longer -- though maybe I'll end up making a 6.2.0 before 6.1.0 gets through the voting process 🤣 )
Once we can cast from `DataType::Null` I think we'll be able to make this work in DataFusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-957138939
I am not sure anymore this is a good idea.
The problem with introducing `null` as scalar is that we lose the type information on the scalar (making everything type `Null`). In order to make this work, the value should be converted to an array of the original type afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1212: add untyped null
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1212:
URL: https://github.com/apache/arrow-datafusion/pull/1212#issuecomment-989135548
I had effectively changed `Expr::Scalar` to report its type as `DataType::Null` its interior `ScalarValue::is_null()` returned true. That seemed fairly promising but I got blocked by the lack of null cast kernels in Arrow.
Now I think we have those kernels it would be useful to try again -- but I am not sure when I will have the time again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org