You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/08 15:24:00 UTC
[jira] [Commented] (DRILL-8039) More LGTM Code Cleanup
[ https://issues.apache.org/jira/browse/DRILL-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17440546#comment-17440546 ]
ASF GitHub Bot commented on DRILL-8039:
---------------------------------------
cgivre opened a new pull request #2365:
URL: https://github.com/apache/drill/pull/2365
# [DRILL-8039](https://issues.apache.org/jira/browse/DRILL-8039): More LGTM Code Cleanup
## Description
This PR fixes a few groups of LGTM issues:
* Hides false positive alerts for Array index out of bounds (10 alerts)
* Comparison of identical values (1 alert)
* Missing format arguments (4 alerts)
* Unused format argument (27 alerts)
* Broken or risky crypto algorithms (2 alerts)
* Implicit conversion from array to String (1 alert)
* Spurious Javadoc (2 files)
None of these affect functionality. Most relate to code maintainability and error messages.
## Documentation
No user facing changes.
## Testing
Ran standard unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> More LGTM Code Cleanup
> ----------------------
>
> Key: DRILL-8039
> URL: https://issues.apache.org/jira/browse/DRILL-8039
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.20.0
>
>
> This PR fixes a few groups of LGTM issues:
> * Hides false positive alerts for Array index out of bounds (10 alerts)
> * Comparison of identical values (1 alert)
> * Missing format arguments (4 alerts)
> * Unused format argument (27 alerts)
> * Broken or risky crypto algorithms (2 alerts)
> * Implicit conversion from array to String (1 alert)
> * Spurious Javadoc (2 files)
> None of these affect functionality. Most relate to code maintainability and error messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)