You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/14 02:01:51 UTC

[GitHub] [pulsar] tomscut opened a new pull request #12028: Fix flaky test ManagedLedgerTest#testMaximumRolloverTime

tomscut opened a new pull request #12028:
URL: https://github.com/apache/pulsar/pull/12028


   Master Issue: [#ISSUE-12019](https://github.com/streamnative/pulsar/issues/3045)
   
   ### Motivation
   
   
   *Fix flaky test ManagedLedgerTest#testMaximumRolloverTime.*
   
   ### Modifications
   
   *Here should sleep within 2 seconds to prevent more than two times rolls of ledger.*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   Need to update docs? 
   - [ ] doc-required   
   - [x] no-need-doc 
   - [ ] doc 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut closed pull request #12028: Fix flaky test ManagedLedgerTest#testMaximumRolloverTime

Posted by GitBox <gi...@apache.org>.
tomscut closed pull request #12028:
URL: https://github.com/apache/pulsar/pull/12028


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tomscut commented on pull request #12028: Fix flaky test ManagedLedgerTest#testMaximumRolloverTime

Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #12028:
URL: https://github.com/apache/pulsar/pull/12028#issuecomment-918803222


   Those unsuccessful checks seem unrelate to the change.
   
   Hi @merlimat @hangc0276 @codelipenghui , could you please review the code? Thanks a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org