You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "efegokdemir (via GitHub)" <gi...@apache.org> on 2026/10/10 04:34:46 UTC
[PR] GH-11468: Distinguish unsupported cast errors [arrow-rs]
efegokdemir opened a new pull request, #11488:
URL: https://github.com/apache/arrow-rs/pull/11488
# Which issue does this PR close?
- Closes #11468
# Rationale for this change
Unsupported source/target type pairs currently fall through to `CastError`, the same error used when a supported conversion cannot convert particular values. This makes callers unable to distinguish an unsupported cast from invalid input. The issue discussion recommends `NotYetImplemented` for unsupported conversions to preserve compatibility.
# What changes are included in this PR?
Unsupported cast dispatch paths now return `ArrowError::NotYetImplemented`. Value-level conversion failures remain `ArrowError::CastError`. Rustdoc and regression tests cover both behaviours.
# Are these changes tested?
- `cargo test -p arrow-cast --all-features` (411 unit, 55 integration, and 15 doc tests passed)
- `cargo fmt --all -- --check`
- `git diff --check`
- `cargo clippy -p arrow-cast --all-targets --all-features -- -D warnings` completed successfully; installed Clippy reported an existing unknown-lint warning for `clippy::assert_is_empty`.
The unsupported-cast regression test failed against the original implementation because it returned the wrong error variant, and passed after this change.
# Are there any significant user-facing changes?
Callers now receive `NotYetImplemented` for unsupported type pairs. Invalid values for supported conversions continue to return `CastError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-11468: Distinguish unsupported cast errors [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11488:
URL: https://github.com/apache/arrow-rs/pull/11488#issuecomment-6095398640
closing for now as id like confirmation theres actually a human in the loop per discussion on https://github.com/apache/arrow-rs/pull/11209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-11468: Distinguish unsupported cast errors [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed pull request #11488: GH-11468: Distinguish unsupported cast errors
URL: https://github.com/apache/arrow-rs/pull/11488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org