[I] [Feature Request]: Add serverID when using download-maven-plugin (hop)

["jballment (via GitHub)" <gi...@apache.org>]

jballment opened a new issue, #9093:
URL: https://github.com/apache/hop/issues/9093

   ### What would you like to happen?
   
   To allow for building Hop behind corporate firewalls, please add serverId to all download-maven-plugin configurations e.g.
   
   <properties>
           <swtbot.plugins.serverId></swtbot.plugins.serverId>
   </properties>
   <plugin>
                   <groupId>com.googlecode.maven-download-plugin</groupId>
                   <artifactId>download-maven-plugin</artifactId>
                   <version>1.9.0</version>
                   <executions>
                       <execution>
                           <id>download-swtbot-finder</id>
                           <goals>
                               <goal>wget</goal>
                           </goals>
                           <phase>generate-resources</phase>
                           <configuration>
                               <url>${swtbot.plugins.url}/${swtbot.finder.file}</url>
                               <outputDirectory>${swtbot.download.dir}</outputDirectory>
                               <outputFileName>${swtbot.finder.file}</outputFileName>
                               <serverId>${swtbot.plugins.serverId}</serverId>
                           </configuration>
                       </execution>
   </plugin>
   
   Updates need to happen in
   
   - lib-p2/swtbot/pom.xml
   - lib-p2/tm4e/pom.xml
   - rap/pom.xml
   
   In rap/pom.xml please also parameterise the URL e.g.
   
       <properties>
           <monaco.download.url>https://registry.npmjs.org/monaco-editor/-/monaco-editor-${monaco.version}.tgz</monaco.download.url>
           <monaco.download.serverId></monaco.download.serverId>
       </properties>
   
   
           <plugins>
               <!-- Download the Monaco Editor npm package at build time -->
               <plugin>
                   <groupId>com.googlecode.maven-download-plugin</groupId>
                   <artifactId>download-maven-plugin</artifactId>
                   <version>1.9.0</version>
                   <executions>
                       <execution>
                           <id>download-monaco-editor</id>
                           <goals>
                               <goal>wget</goal>
                           </goals>
                           <phase>generate-resources</phase>
                           <configuration>
                               <url>${monaco.download.url}</url>
                               <serverId>${monaco.download.serverId}</serverId>
                               <unpack>true</unpack>
                               <outputDirectory>${project.build.directory}/monaco-download</outputDirectory>
                           </configuration>
                       </execution>
                   </executions>
               </plugin>
   
    These changes will allow command-line override of URLs and serverIds to allow the downloading from an internal maven repository.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Add serverID when using download-maven-plugin (hop)

["hansva (via GitHub)" <gi...@apache.org>]

hansva closed issue #9093: [Feature Request]: Add serverID when using download-maven-plugin
URL: https://github.com/apache/hop/issues/9093


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Add serverID when using download-maven-plugin (hop)

["bamaer (via GitHub)" <gi...@apache.org>]

bamaer commented on issue #9093:
URL: https://github.com/apache/hop/issues/9093#issuecomment-6357445394

   @jballment most of this is already possible:
   
   - The SWTBot and TM4E URLs are properties: [`swtbot.plugins.url`](https://github.com/apache/hop/blob/main/lib-p2/swtbot/pom.xml#L43) and [`tm4e.core.download.url`](https://github.com/apache/hop/blob/main/lib-p2/tm4e/pom.xml#L40).
   - The download plugin reads its server id from the property `download.auth.serverId`, so `-Ddownload.auth.serverId=<id>` (or the same in a `settings.xml` profile) gives all of these downloads your credentials. No per-download serverId is needed.
   - The Monaco URL in `rap/pom.xml` is the only one that's hardcoded. I'll make that a property (`monaco.download.url`) and document the setup in the dev manual.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org