[jira] Resolved: (BUILDR-218) Manifest.from_zip fails if the zip doesn't already have META-INF/MANIFEST.MF

["Assaf Arkin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BUILDR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Assaf Arkin resolved BUILDR-218.
--------------------------------

    Resolution: Fixed

> Manifest.from_zip fails if the zip doesn't already have META-INF/MANIFEST.MF
> ----------------------------------------------------------------------------
>
>                 Key: BUILDR-218
>                 URL: https://issues.apache.org/jira/browse/BUILDR-218
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>         Attachments: 01_spec_for_manifest_bug.patch, 02_patch_for_manifest_bug.patch
>
>
> in java/packaging.rb:
>         def from_zip(file)
>             Zip::ZipFile.open(file.to_s) do |zip|
>               return Manifest.new unless zip.get_entry('META-INF/MANIFEST.MF')
>               Manifest.parse zip.read('META-INF/MANIFEST.MF')
>             end
>           end
> zip.get_entry fails with an exception if the entry doesn't exist, so the whole method fails

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.