You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Eugene Fedotov (JIRA)" <ji...@apache.org> on 2012/08/29 15:05:07 UTC
[jira] [Created] (DIGESTER-167) Groundless "Circular file inclusion
detected" exception when including rules XML file
Eugene Fedotov created DIGESTER-167:
---------------------------------------
Summary: Groundless "Circular file inclusion detected" exception when including rules XML file
Key: DIGESTER-167
URL: https://issues.apache.org/jira/browse/DIGESTER-167
Project: Commons Digester
Issue Type: Bug
Affects Versions: 3.2
Reporter: Eugene Fedotov
Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
<digester-rules>
<pattern value="root/foo">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
<pattern value="root/foo2">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
</digester-rules>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIGESTER-167) Groundless "Circular file inclusion
detected" exception when including rules XML file
Posted by "Eugene Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Fedotov updated DIGESTER-167:
------------------------------------
Description:
Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
rules1.xml
<?xml version="1.0"?>
<!DOCTYPE digester-rules PUBLIC
"-//Apache Commons //DTD digester-rules XML V1.0//EN"
"http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
<digester-rules>
<pattern value="root/foo">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
<pattern value="root/foo2">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
</digester-rules>
rules2.xml
<?xml version="1.0"?>
<!DOCTYPE digester-rules PUBLIC
"-//Apache Commons //DTD digester-rules XML V1.0//EN"
"http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
<digester-rules>
<pattern value="bar">
<object-create-rule classname="Bar"/>
</pattern>
</digester-rules>
was:
Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
<digester-rules>
<pattern value="root/foo">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
<pattern value="root/foo2">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
</digester-rules>
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> rules2.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIGESTER-167) Groundless "Circular file inclusion
detected" exception when including rules XML file
Posted by "Eugene Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Fedotov updated DIGESTER-167:
------------------------------------
Attachment: (was: IncludeRule.zip)
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
> Assignee: Simone Tripodi
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> {code}
> rules2.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-167) Groundless "Circular file
inclusion detected" exception when including rules XML file
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444966#comment-13444966 ]
Simone Tripodi commented on DIGESTER-167:
-----------------------------------------
Could you please provide the patch as a single {{.patch}} file, rather than splitted patches in a {{.zip}} archive?
Please take care also on respecting the original code format and have a look at [On Contributing Patches|http://commons.apache.org/patches.html]
TIA!
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
> Assignee: Simone Tripodi
> Attachments: IncludeRule.zip
>
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> {code}
> rules2.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (DIGESTER-167) Groundless "Circular file
inclusion detected" exception when including rules XML file
Posted by "Eugene Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444926#comment-13444926 ]
Eugene Fedotov edited comment on DIGESTER-167 at 8/30/12 11:55 PM:
-------------------------------------------------------------------
The patch (for DIGESTER3_3_2 branch).
was (Author: eugene_fedotov):
The patch.
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
> Attachments: IncludeRule.zip
>
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> rules2.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIGESTER-167) Groundless "Circular file inclusion
detected" exception when including rules XML file
Posted by "Eugene Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Fedotov updated DIGESTER-167:
------------------------------------
Attachment: IncludeRule.zip
The patch.
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
> Attachments: IncludeRule.zip
>
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> rules2.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIGESTER-167) Groundless "Circular file inclusion
detected" exception when including rules XML file
Posted by "Eugene Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Fedotov updated DIGESTER-167:
------------------------------------
Attachment: DIGESTER-167.patch
The patch is submitted as single file.
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
> Assignee: Simone Tripodi
> Attachments: DIGESTER-167.patch
>
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> {code}
> rules2.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-167) Groundless "Circular file
inclusion detected" exception when including rules XML file
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444129#comment-13444129 ]
Simone Tripodi commented on DIGESTER-167:
-----------------------------------------
Good catch - any chance you can submit a patch (with testcase included)?
TIA!
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> rules2.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DIGESTER-167) Groundless "Circular file
inclusion detected" exception when including rules XML file
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi resolved DIGESTER-167.
-------------------------------------
Resolution: Fixed
Fix Version/s: 3.3
patch applied, just fixed some code formats - see r1382109
Thanks for contributing, Eugene! :)
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
> Assignee: Simone Tripodi
> Fix For: 3.3
>
> Attachments: DIGESTER-167.patch
>
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> {code}
> rules2.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIGESTER-167) Groundless "Circular file inclusion
detected" exception when including rules XML file
Posted by "Simone Tripodi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi updated DIGESTER-167:
------------------------------------
Description:
Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
rules1.xml
{code:xml}
<?xml version="1.0"?>
<!DOCTYPE digester-rules PUBLIC
"-//Apache Commons //DTD digester-rules XML V1.0//EN"
"http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
<digester-rules>
<pattern value="root/foo">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
<pattern value="root/foo2">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
</digester-rules>
{code}
rules2.xml
{code:xml}
<?xml version="1.0"?>
<!DOCTYPE digester-rules PUBLIC
"-//Apache Commons //DTD digester-rules XML V1.0//EN"
"http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
<digester-rules>
<pattern value="bar">
<object-create-rule classname="Bar"/>
</pattern>
</digester-rules>
{code}
was:
Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
rules1.xml
<?xml version="1.0"?>
<!DOCTYPE digester-rules PUBLIC
"-//Apache Commons //DTD digester-rules XML V1.0//EN"
"http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
<digester-rules>
<pattern value="root/foo">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
<pattern value="root/foo2">
<object-create-rule classname="Foo"/>
<include url="classpath:/rules2.xml"/>
</pattern>
</digester-rules>
rules2.xml
<?xml version="1.0"?>
<!DOCTYPE digester-rules PUBLIC
"-//Apache Commons //DTD digester-rules XML V1.0//EN"
"http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
<digester-rules>
<pattern value="bar">
<object-create-rule classname="Bar"/>
</pattern>
</digester-rules>
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
> Key: DIGESTER-167
> URL: https://issues.apache.org/jira/browse/DIGESTER-167
> Project: Commons Digester
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Eugene Fedotov
> Attachments: IncludeRule.zip
>
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="root/foo">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> <pattern value="root/foo2">
> <object-create-rule classname="Foo"/>
> <include url="classpath:/rules2.xml"/>
> </pattern>
> </digester-rules>
> {code}
> rules2.xml
> {code:xml}
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
> "-//Apache Commons //DTD digester-rules XML V1.0//EN"
> "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
> <pattern value="bar">
> <object-create-rule classname="Bar"/>
> </pattern>
> </digester-rules>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira