You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/02/21 10:15:03 UTC
[GitHub] [incubator-pekko-http] jrudolph opened a new pull request, #74: make sure that no pekko version specified to build against is same as "default"
jrudolph opened a new pull request, #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74
That fixes the nightly tests which only accidentally worked before and when fixing the akka->pekko prefix in f47c735e20d62fa58ce81e43cb4f5d82a1c9272b broke because "default" started to refer to pekko 1.0.0 which is not yet released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #74: make sure that no pekko version specified to build against is same as "default"
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #74: make sure that no pekko version specified to build against is same as "default"
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74#discussion_r1112887619
##########
project/PekkoDependency.scala:
##########
@@ -45,9 +45,8 @@ object PekkoDependency {
// (typically for the docs that require 2.6)
if (defaultVersion.startsWith("1.0")) Artifact(determineLatestSnapshot("0.0.0"), true)
else Artifact(defaultVersion)
- case Some("default") => Artifact(defaultVersion)
- case Some(other) => Artifact(other, true)
- case None =>
+ case Some(other) => Artifact(other, true)
+ case Some("default") | None =>
Review Comment:
But actually the ordering of clauses was now wrong... Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #74: make sure that no pekko version specified to build against is same as "default"
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74#discussion_r1112887651
##########
project/PekkoDependency.scala:
##########
@@ -45,9 +45,8 @@ object PekkoDependency {
// (typically for the docs that require 2.6)
if (defaultVersion.startsWith("1.0")) Artifact(determineLatestSnapshot("0.0.0"), true)
else Artifact(defaultVersion)
- case Some("default") => Artifact(defaultVersion)
- case Some(other) => Artifact(other, true)
- case None =>
+ case Some(other) => Artifact(other, true)
+ case Some("default") | None =>
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #74: make sure that no pekko version specified to build against is same as "default"
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74#issuecomment-1438320111
:+1: Nightlies green again: https://github.com/apache/incubator-pekko-http/actions/runs/4232112501/jobs/7351447416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #74: make sure that no pekko version specified to build against is same as "default"
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74#discussion_r1112886300
##########
project/PekkoDependency.scala:
##########
@@ -45,9 +45,8 @@ object PekkoDependency {
// (typically for the docs that require 2.6)
if (defaultVersion.startsWith("1.0")) Artifact(determineLatestSnapshot("0.0.0"), true)
else Artifact(defaultVersion)
- case Some("default") => Artifact(defaultVersion)
- case Some(other) => Artifact(other, true)
- case None =>
+ case Some(other) => Artifact(other, true)
+ case Some("default") | None =>
Review Comment:
It doesn't have to be changed later, these two are actually supposed to be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #74: make sure that no pekko version specified to build against is same as "default"
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74#issuecomment-1438261746
Code is not formatted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #74: make sure that no pekko version specified to build against is same as "default"
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #74:
URL: https://github.com/apache/incubator-pekko-http/pull/74#discussion_r1112873237
##########
project/PekkoDependency.scala:
##########
@@ -45,9 +45,8 @@ object PekkoDependency {
// (typically for the docs that require 2.6)
if (defaultVersion.startsWith("1.0")) Artifact(determineLatestSnapshot("0.0.0"), true)
else Artifact(defaultVersion)
- case Some("default") => Artifact(defaultVersion)
- case Some(other) => Artifact(other, true)
- case None =>
+ case Some(other) => Artifact(other, true)
+ case Some("default") | None =>
Review Comment:
Can we add a `NOTE` here stating that this should be reverted once a pekko release is made?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org