You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/03 06:16:09 UTC

[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #10558: Add with clause for Oracle `SELECT` statement

ThanoshanMV commented on a change in pull request #10558:
URL: https://github.com/apache/shardingsphere/pull/10558#discussion_r644513278



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DMLStatement.g4
##########
@@ -121,7 +121,223 @@ unionClause
     ;
 
 queryBlock
-    : SELECT duplicateSpecification? projections fromClause? whereClause? groupByClause? havingClause?
+    : withClause? SELECT duplicateSpecification? projections fromClause? whereClause? groupByClause? havingClause?

Review comment:
       Hi @wgy8283335, yes the above-mentioned rules aren't aligned with Oracle documentation rules. Since `withClause` contains a lot of changes, I only put `withClause` definition in this PR. I thought to proofread each rule in the `queryBlock` with seperate PRs. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org