[GitHub] [accumulo] ctubbsii commented on pull request #1780: Upgrade Thrift to 0.13.0

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #1780:
URL: https://github.com/apache/accumulo/pull/1780#issuecomment-728213014


   Thanks for the PR, @BukrosSzabolcs . Thrift upgrades are always highly disruptive for us, as they involve (at minimum):
   
   1. Updates to pom.xml files
   2. Updates to our build scripts to generate and place generated Java code
   3. Remove any obsoleted workarounds we've added due to bugs in earlier Thrift releases
   4. Regenerate and check in new generated Thrift code (and remove any old stuff) (in a separate commit)
   5. Fix / workaround any new bugs caused by changes in Thrift libraries
   6. Ensure upgrades work across Accumulo versions that change the Thrift version
   7. Test, test, test
   
   I think your PR is a good start, but there's lots more to do to be confident about a Thrift version bump, and I'm not sure whether we're going to want to do that for 2.1 yet or not. When we are ready to update, we will certainly include your changes. However, I wanted to offer an explanation in case you don't see this merged right away.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org