You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/08/21 20:15:25 UTC
[GitHub] [struts] JCgH4164838Gh792C124B5 opened a new pull request #433: WW-5075 Fixes for OSGi plugin in 2.6.x
JCgH4164838Gh792C124B5 opened a new pull request #433:
URL: https://github.com/apache/struts/pull/433
Initial attempt to fix OSGi Plugin issues discovered during examination of WW-5075.
- Draws on PR#427 and utilizes similar code, but updated for JDK8.
- Updated OSGi plugin dependencies to OSGi R7.
- Indication is that the OSGi Plugin has been failing since Struts 2.3.4.
- Applied fix to ResourceFinder to restore 2.3.x logic that was broken in 2.5.x.
- Implemented changes to restore OSGi Plugin functionality for 2.6.x.
- Applied changes to the OSGi Admin Bundle to function under 2.6.x.
- Applied changes to the OSGi Demo Bundle to function under 2.6.x.
- Updated the OSGi Admin Bundle JS libraries and related CSS to newer versions.
- Added new unit tests for the OSGi plugin.
- The OSGi plugin will only function properly with exploded/expanded WAR files.
- BundlePackageLoader changes suggested by L. Lenart (from PR#427).
- FelixOsgiHost changes to better handle Felix bundle cache location processing (Windows and Linux).
- FelixOsgIHost test modified to not fail if felix-cache directory cannot be created (warn only) to avoid failing the whole build.
- FelixOsgIHost test modified to not fail if felix-cache directory bundle load issues arise (warn only) to avoid failing the whole build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] lukaszlenart merged pull request #433: WW-5075 Fixes for OSGi plugin in 2.6.x
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #433:
URL: https://github.com/apache/struts/pull/433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] coveralls commented on pull request #433: WW-5075 Fixes for OSGi plugin in 2.6.x
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #433:
URL: https://github.com/apache/struts/pull/433#issuecomment-678479140
[](https://coveralls.io/builds/32922381)
Coverage increased (+0.1%) to 49.532% when pulling **cb3ca4b3111474a309a50b644e0c43095e9367b5 on JCgH4164838Gh792C124B5:WW-5075_S2_6_OSGiPluginUpdate** into **6d865b6aa08b4327ad2049d576b838990cf2077d on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #433: WW-5075 Fixes for OSGi plugin in 2.6.x
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #433:
URL: https://github.com/apache/struts/pull/433#issuecomment-678480590
Hello Apache Struts Team.
This PR is an equivalent to PR #427, but for the 2.6.x mainline branch, and containing some JDK8+ code structure changes.
A few additional corrections were found during this PR for 2.6, and a back-port of applicable items to 2.5.x may be provided in a separate PR.
Please let me know if you notice any issues with the PR that should be addressed.
Note: I encountered some weird issues when trying to build with JDK 11 / Windows (besides the usual Apache Rat issue). The build ran fine under JDK 8, in the same environment. The issue seems to be related to the Maven/Surefire/Jetty processing for the Showcase App unit tests, possibly combined with launching via NetBeans 12 (IDE). It does not appear to have anything to do with the changes in this PR, but it may be something to look at in the future. The build worked fine for Travis CI, so it must only impact some environment configurations (possibly only Windows).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org