You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 06:06:03 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
wangyang0918 opened a new pull request #12143:
URL: https://github.com/apache/flink/pull/12143
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
After FLINK-13938, we could support to register remote shared libs as Yarn local resources and prevent unnecessary uploading and downloading for system Flink jars.
However, we still need to specify a local user jar to run a Flink job on Yarn. This ticket aims to add the remote path support. It have at least two purposes.
* Accelerate the submission
* Better integration with application mode. Since the user main code is executed in the cluster(jobmanager), we do not need the user jar exists locally.
A very typical use case is like following.
```
./bin/flink run-application -p 10 -t yarn-application \
-yD yarn.provided.lib.dirs="hdfs://myhdfs/flink/lib" \
hdfs://myhdfs/jars/WindowJoin.jar
```
## Brief change log
* `a251fc` Always build the packaged program in the cluster for application mode
* `9c3e41` Support to specify a remote path for job jar
* `f257f9` Move some variables as member of YarnApplicationFileUploader to make it more self-contained
## Verifying this change
* New added unit tests
* ITCase for Yarn application mode
* Manually test in a real Yarn cluster
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (will add document in a separate ticket with all other application features)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a04e667d39cec33b375a0ae8983f1afad916f812 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261)
* dcd8b8efec513fcfa4d833ab2915e7171eee6ace UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
}, {
"hash" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360",
"triggerID" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"triggerType" : "PUSH"
}, {
"hash" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dcd8b8efec513fcfa4d833ab2915e7171eee6ace Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324)
* 0815d70382a6f6630beca0aff985e8dfdf480d32 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360)
* cbaf6e2779ce08f2e38fd84522fa1a6843468e83 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628708705
@kl0u The pre-check in the getRemoteSharedPaths is a good idea. It could make the submission fails fast if the yarn.provided.lib.dirs is wrongly configured to local directories.
Thanks a lot for your review. I have addressed all the comments in your branch and force-pushed. Please have another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dcd8b8efec513fcfa4d833ab2915e7171eee6ace Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #12143:
URL: https://github.com/apache/flink/pull/12143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628408733
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f257f908133b924d5d1b52d4b01afe80a7e62ebe (Thu May 14 06:08:44 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a04e667d39cec33b375a0ae8983f1afad916f812 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f257f908133b924d5d1b52d4b01afe80a7e62ebe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #12143:
URL: https://github.com/apache/flink/pull/12143#discussion_r434449857
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -733,67 +737,49 @@ private ApplicationReport startAppMaster(
1));
}
- final Set<File> userJarFiles = new HashSet<>();
+ final Set<Path> userJarFiles = new HashSet<>();
if (jobGraph != null) {
- userJarFiles.addAll(jobGraph.getUserJars().stream().map(f -> f.toUri()).map(File::new).collect(Collectors.toSet()));
+ userJarFiles.addAll(jobGraph.getUserJars().stream().map(f -> f.toUri()).map(Path::new).collect(Collectors.toSet()));
}
final List<URI> jarUrls = ConfigUtils.decodeListFromConfig(configuration, PipelineOptions.JARS, URI::create);
if (jarUrls != null && YarnApplicationClusterEntryPoint.class.getName().equals(yarnClusterEntrypoint)) {
- userJarFiles.addAll(jarUrls.stream().map(File::new).collect(Collectors.toSet()));
+ userJarFiles.addAll(jarUrls.stream().map(Path::new).collect(Collectors.toSet()));
}
- int yarnFileReplication = yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY, DFSConfigKeys.DFS_REPLICATION_DEFAULT);
- int fileReplication = configuration.getInteger(YarnConfigOptions.FILE_REPLICATION);
- fileReplication = fileReplication > 0 ? fileReplication : yarnFileReplication;
-
// only for per job mode
if (jobGraph != null) {
for (Map.Entry<String, DistributedCache.DistributedCacheEntry> entry : jobGraph.getUserArtifacts().entrySet()) {
- org.apache.flink.core.fs.Path path = new org.apache.flink.core.fs.Path(entry.getValue().filePath);
// only upload local files
- if (!path.getFileSystem().isDistributedFS()) {
- Path localPath = new Path(path.getPath());
+ if (Utils.isRemotePath(entry.getValue().filePath)) {
Review comment:
Here the comment said that `only upload local files`, but the logic in `if` will be true only for `RemotePath`, so maybe this is a bug? @wangyang0918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f257f908133b924d5d1b52d4b01afe80a7e62ebe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246)
* a04e667d39cec33b375a0ae8983f1afad916f812 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
}, {
"hash" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360",
"triggerID" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"triggerType" : "PUSH"
}, {
"hash" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1376",
"triggerID" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dcd8b8efec513fcfa4d833ab2915e7171eee6ace Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324)
* 0815d70382a6f6630beca0aff985e8dfdf480d32 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360)
* cbaf6e2779ce08f2e38fd84522fa1a6843468e83 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1376)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f257f908133b924d5d1b52d4b01afe80a7e62ebe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246)
* a04e667d39cec33b375a0ae8983f1afad916f812 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628430911
cc @kl0u since it is part of FLIP-85(application mode). Could you help with review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
}, {
"hash" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360",
"triggerID" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"triggerType" : "PUSH"
}, {
"hash" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1376",
"triggerID" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbaf6e2779ce08f2e38fd84522fa1a6843468e83 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1376)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628995582
rebase latest master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f257f908133b924d5d1b52d4b01afe80a7e62ebe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246)
* a04e667d39cec33b375a0ae8983f1afad916f812 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
}, {
"hash" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360",
"triggerID" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dcd8b8efec513fcfa4d833ab2915e7171eee6ace Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324)
* 0815d70382a6f6630beca0aff985e8dfdf480d32 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
}, {
"hash" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360",
"triggerID" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"triggerType" : "PUSH"
}, {
"hash" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1376",
"triggerID" : "cbaf6e2779ce08f2e38fd84522fa1a6843468e83",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0815d70382a6f6630beca0aff985e8dfdf480d32 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1360)
* cbaf6e2779ce08f2e38fd84522fa1a6843468e83 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1376)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
}, {
"hash" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0815d70382a6f6630beca0aff985e8dfdf480d32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dcd8b8efec513fcfa4d833ab2915e7171eee6ace Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324)
* 0815d70382a6f6630beca0aff985e8dfdf480d32 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628562252
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #12143:
URL: https://github.com/apache/flink/pull/12143#discussion_r434464224
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -733,67 +737,49 @@ private ApplicationReport startAppMaster(
1));
}
- final Set<File> userJarFiles = new HashSet<>();
+ final Set<Path> userJarFiles = new HashSet<>();
if (jobGraph != null) {
- userJarFiles.addAll(jobGraph.getUserJars().stream().map(f -> f.toUri()).map(File::new).collect(Collectors.toSet()));
+ userJarFiles.addAll(jobGraph.getUserJars().stream().map(f -> f.toUri()).map(Path::new).collect(Collectors.toSet()));
}
final List<URI> jarUrls = ConfigUtils.decodeListFromConfig(configuration, PipelineOptions.JARS, URI::create);
if (jarUrls != null && YarnApplicationClusterEntryPoint.class.getName().equals(yarnClusterEntrypoint)) {
- userJarFiles.addAll(jarUrls.stream().map(File::new).collect(Collectors.toSet()));
+ userJarFiles.addAll(jarUrls.stream().map(Path::new).collect(Collectors.toSet()));
}
- int yarnFileReplication = yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY, DFSConfigKeys.DFS_REPLICATION_DEFAULT);
- int fileReplication = configuration.getInteger(YarnConfigOptions.FILE_REPLICATION);
- fileReplication = fileReplication > 0 ? fileReplication : yarnFileReplication;
-
// only for per job mode
if (jobGraph != null) {
for (Map.Entry<String, DistributedCache.DistributedCacheEntry> entry : jobGraph.getUserArtifacts().entrySet()) {
- org.apache.flink.core.fs.Path path = new org.apache.flink.core.fs.Path(entry.getValue().filePath);
// only upload local files
- if (!path.getFileSystem().isDistributedFS()) {
- Path localPath = new Path(path.getPath());
+ if (Utils.isRemotePath(entry.getValue().filePath)) {
Review comment:
@klion26 Thanks for your comments about this. It is indeed a bug and should be fixed in 1.11. I will create a ticket right now. Moreover, i will dig in and find why the related tests does not fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12143: [FLINK-17632][yarn] Support to specify a remote path for job jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12143:
URL: https://github.com/apache/flink/pull/12143#issuecomment-628420573
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1246",
"triggerID" : "f257f908133b924d5d1b52d4b01afe80a7e62ebe",
"triggerType" : "PUSH"
}, {
"hash" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261",
"triggerID" : "a04e667d39cec33b375a0ae8983f1afad916f812",
"triggerType" : "PUSH"
}, {
"hash" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324",
"triggerID" : "dcd8b8efec513fcfa4d833ab2915e7171eee6ace",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a04e667d39cec33b375a0ae8983f1afad916f812 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1261)
* dcd8b8efec513fcfa4d833ab2915e7171eee6ace Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1324)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org