[incubator-superset] branch master updated: [bugfix] throw "TypeError: 'NoneType'..." when save chart to new/existing dash. (#5835)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 5241486  [bugfix] throw "TypeError: 'NoneType'..." when save chart to new/existing dash. (#5835)
5241486 is described below

commit 52414869714d2ae0a31607593dcbdbdcc8b8cdbc
Author: hitdemo <hi...@gmail.com>
AuthorDate: Fri Mar 22 12:03:53 2019 +0800

    [bugfix] throw "TypeError: 'NoneType'..." when save chart to new/existing dash. (#5835)
---
 superset/views/core.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index eb15dad..7e6d9d3 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1437,7 +1437,7 @@ class Superset(BaseSupersetView):
         """Save or overwrite a slice"""
         slice_name = args.get('slice_name')
         action = args.get('action')
-        form_data, _ = self.get_form_data()
+        form_data, unused_slc = self.get_form_data()
 
         if action in ('saveas'):
             if 'slice_id' in form_data:
@@ -1474,7 +1474,7 @@ class Superset(BaseSupersetView):
                     status=400)
 
             flash(
-                'Slice [{}] was added to dashboard [{}]'.format(
+                _('Chart [{}] was added to dashboard [{}]').format(
                     slc.slice_name,
                     dash.dashboard_title),
                 'info')
@@ -1490,8 +1490,8 @@ class Superset(BaseSupersetView):
                 dashboard_title=request.args.get('new_dashboard_name'),
                 owners=[g.user] if g.user else [])
             flash(
-                'Dashboard [{}] just got created and slice [{}] was added '
-                'to it'.format(
+                _('Dashboard [{}] just got created and chart [{}] was added '
+                  'to it').format(
                     dash.dashboard_title,
                     slc.slice_name),
                 'info')