[GitHub] flink pull request #6153: [FLINK-9557] [formats] Parse 'integer' type as Big...

[twalthr <gi...@git.apache.org>]

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/6153

    [FLINK-9557] [formats] Parse 'integer' type as BigDecimal

    ## What is the purpose of the change
    
    This PR changes the behavior of how a JSON schema is converted into type information for the `integer` type. Currently, we treat `integer` as a BigInteger. However, the Table and SQL API are not able to handle BigInteger and this cannot be changed easily because there is no equivalent SQL type but only `DECIMAL`. In order to avoid confusion for users and support end-to-end use cases that read and write to JSON formatted connectors, the best solution is to treat `integer` as BigDecimal. The serializers/deserializers still support BigInteger for specific use cases.
    
    
    ## Brief change log
    
    - Change default behavior of the JSON schema converter
    
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-9557

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6153
    
----
commit 5594557e89687c566165a4d102783d92fe71b326
Author: Timo Walther <tw...@...>
Date:   2018-06-12T12:51:20Z

    [FLINK-9557] [formats] Parse 'integer' type as BigDecimal

----


---

[GitHub] flink issue #6153: [FLINK-9557] [formats] Parse 'integer' type as BigDecimal

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/6153
  
    Looks good.
    +1 to merge


---

[GitHub] flink issue #6153: [FLINK-9557] [formats] Parse 'integer' type as BigDecimal

[twalthr <gi...@git.apache.org>]

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6153
  
    The change is also compliant to the JSON schema standard:
    ```
    Note that JSON Schema vocabularies are free to define their own
       extended type system.  This should not be confused with the core data
       model types defined here.  As an example, "integer" is a reasonable
       type for a vocabulary to define as a value for a keyword, but the
       data model makes no distinction between integers and other numbers.
    ```
    https://www.ietf.org/id/draft-handrews-json-schema-01.txt


---

[GitHub] flink pull request #6153: [FLINK-9557] [formats] Parse 'integer' type as Big...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6153


---