You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/06/03 13:56:47 UTC

[GitHub] [netbeans] oyarzun commented on a change in pull request #2015: [NETBEANS-3342] Fix Netbeans Installer on macOS with Java 8 and 11

oyarzun commented on a change in pull request #2015:
URL: https://github.com/apache/netbeans/pull/2015#discussion_r434586637



##########
File path: nbi/engine/build.xml
##########
@@ -20,10 +20,17 @@
 
 -->
 
-<project name="NBI_Engine" default="default" basedir=".">
+<project name="nbi/engine" default="default" basedir=".">

Review comment:
       @arusinha when you have time to circle back to this, I have a new branch that has this fix working without using `projectized.xml`. 
   
   https://github.com/oyarzun/netbeans/commit/cba705bde9c76c0a65cbd5e2dfaac757660d92fe
   
   Let me know if you want me to submit a new PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists