You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Bolke de Bruin <bd...@gmail.com> on 2019/08/13 18:46:17 UTC
Review Request 71282: Expose total count of index searches
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71282/
-----------------------------------------------------------
Review request for atlas, Nixon Rodrigues and Saqeeb Shaikh.
Bugs: https://issues.apache.org/jira/browse/ATLAS-3367
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3367
Repository: atlas
Description
-------
Both ElasticSearch and SOLR can expose the total count
of results without returning all results. This is useful
to give the user or client an idea how many results there are.
This patch ensures the total is returned if available. This total
is an approximate as scrubbing of the results still needs to happen.
Therefore, one should not only rely on this information to provide
,for example, pagination.
Diffs
-----
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java d274cc07e
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java c67e34772
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 1dd1afaa3
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 0ffd61c07
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java a7ccaebc8
Diff: https://reviews.apache.org/r/71282/diff/1/
Testing
-------
Thanks,
Bolke de Bruin
Re: Review Request 71282: Expose total count of index searches
Posted by Bolke de Bruin <bd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71282/
-----------------------------------------------------------
(Updated Aug. 20, 2019, 9:47 a.m.)
Review request for atlas, Nixon Rodrigues and Saqeeb Shaikh.
Changes
-------
use approx
Bugs: https://issues.apache.org/jira/browse/ATLAS-3367
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3367
Repository: atlas
Description
-------
Both ElasticSearch and SOLR can expose the total count
of results without returning all results. This is useful
to give the user or client an idea how many results there are.
This patch ensures the total is returned if available. This total
is an approximate as scrubbing of the results still needs to happen.
Therefore, one should not only rely on this information to provide
,for example, pagination.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java d274cc07e
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 479ddfd89
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java c67e34772
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java f7d8f08c7
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 1dd1afaa3
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 0ffd61c07
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java a7ccaebc8
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java c253d544b
Diff: https://reviews.apache.org/r/71282/diff/3/
Changes: https://reviews.apache.org/r/71282/diff/2-3/
Testing
-------
Thanks,
Bolke de Bruin
Re: Review Request 71282: Expose total count of index searches
Posted by Bolke de Bruin <bd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71282/
-----------------------------------------------------------
(Updated Aug. 13, 2019, 7:22 p.m.)
Review request for atlas, Nixon Rodrigues and Saqeeb Shaikh.
Bugs: https://issues.apache.org/jira/browse/ATLAS-3367
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3367
Repository: atlas
Description
-------
Both ElasticSearch and SOLR can expose the total count
of results without returning all results. This is useful
to give the user or client an idea how many results there are.
This patch ensures the total is returned if available. This total
is an approximate as scrubbing of the results still needs to happen.
Therefore, one should not only rely on this information to provide
,for example, pagination.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java d274cc07e
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 479ddfd89
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java c67e34772
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java f7d8f08c7
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 1dd1afaa3
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 0ffd61c07
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java a7ccaebc8
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java c253d544b
Diff: https://reviews.apache.org/r/71282/diff/2/
Changes: https://reviews.apache.org/r/71282/diff/1-2/
Testing
-------
Thanks,
Bolke de Bruin