[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3475: ARTEMIS-3133 Just Encapsulating ObjectPool into a small utility

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #3475:
URL: https://github.com/apache/activemq-artemis/pull/3475#discussion_r587188621



##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ObjectPool.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils;
+
+import java.util.Queue;
+import java.util.function.Consumer;
+import java.util.function.Supplier;
+
+import io.netty.util.internal.PlatformDependent;
+
+/**
+ * A simple encapsulation of Netty MpscQueue to provide a pool of objects.
+ * @param <T>
+ */
+public class ObjectPool<T> {
+
+   private final Queue<T> internalPool;
+
+   private final Consumer<T> cleaner;
+   private final Supplier<T> supplier;
+
+   public ObjectPool(int maxSize, Consumer<T> cleaner, Supplier<T> supplier) {
+      if (maxSize > 0) {
+         internalPool = PlatformDependent.newFixedMpscQueue(maxSize);

Review comment:
       This is the complex part: this queue work correctly only if there are multiple producers and a single consumer ie it breaks with many parallel consumers.
   I am not sure I would create a general purpose utility for this reason, because the use case is very narrow and difficult to be enforced...
   In addition, it seems that's used in case no pool is needed, that means 
   
   1) we pay several additional costs just to create the other object
   2) we always create the object pool itself
   
   We can use a JMH bench so I can show better what I mean
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org