You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/13 14:33:34 UTC

[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #9519: [dashboard] New, add statsd incr to the API

craig-rueda commented on a change in pull request #9519: [dashboard] New, add statsd incr to the API
URL: https://github.com/apache/incubator-superset/pull/9519#discussion_r407509348
 
 

 ##########
 File path: superset/dashboards/api.py
 ##########
 @@ -160,19 +160,25 @@ def post(self) -> Response:
             500:
               $ref: '#/components/responses/500'
         """
+        self.incr_stats("init", self.post.__name__)
 
 Review comment:
   Can we dry this up? Why not just increment inside of `response_xxx` and set the method name in `@expose`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org