You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/10/24 19:29:27 UTC

[GitHub] [incubator-heron] armadillojim opened a new issue #3622: rename "topology master" to "topology manager"?

armadillojim opened a new issue #3622:
URL: https://github.com/apache/incubator-heron/issues/3622


   Howdy!  I'm relatively new to Heron, and it seems like a wonderful product.  Thanks for all your hard work in developing it!
   
   As a newbie I've been reading through the documentation.  One thing caught my eye: the term "topology master".  Other components don't use the same word.  For example, there are the "metrics manager", "stream manager", and "zoo keeper".
   
   If I submitted a PR to change "master" to "manager", would that be well received?  Or would such a change not be welcome?  I searched through all the issues and PRs but didn't see anything related.  Forgive me if this conversation has already been hashed through.  Also, FWIW I'm suggesting "manager" in place of "master" to keep with a word beginning with "m"; that way the abbreviation "TM" doesn't change.  However, perhaps someone else could come up with a more appropriate suggestion.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] armadillojim closed issue #3622: rename "topology master" to "topology manager"?

Posted by GitBox <gi...@apache.org>.
armadillojim closed issue #3622:
URL: https://github.com/apache/incubator-heron/issues/3622


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] nicknezis commented on issue #3622: rename "topology master" to "topology manager"?

Posted by GitBox <gi...@apache.org>.
nicknezis commented on issue #3622:
URL: https://github.com/apache/incubator-heron/issues/3622#issuecomment-716062099


   I think it's a good idea. I'd be willing to review your merge request and test it out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-heron] armadillojim commented on issue #3622: rename "topology master" to "topology manager"?

Posted by GitBox <gi...@apache.org>.
armadillojim commented on issue #3622:
URL: https://github.com/apache/incubator-heron/issues/3622#issuecomment-716908764


   Thanks so much, @nicknezis!  I just created #3624.
   
   I haven't done testing yet as the edits took me much longer than I originally anticipated.  However, I will try my best to do so over the next few days.  Any suggestions are welcome!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org