You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:53:03 UTC
[GitHub] [incubator-pagespeed-mod] wernight opened a new pull request #2021: Update build_ngx_pagespeed_from_source.html
wernight opened a new pull request #2021:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2021
Simplify a bit the manual compilation by avoiding temporary files and guessing some filenames.
Note: Currently it still contains a lot of legacy code. I suggest to have the build instruction under source control. This would not only be expected, it'd also avoid having this script remain backward compatible.
See also https://github.com/wernight/docker-alpine-nginx-pagespeed/issues/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf merged pull request #2021: Update build_ngx_pagespeed_from_source.html
Posted by GitBox <gi...@apache.org>.
oschaaf merged pull request #2021:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] wernight edited a comment on pull request #2021: Update build_ngx_pagespeed_from_source.html
Posted by GitBox <gi...@apache.org>.
wernight edited a comment on pull request #2021:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2021#issuecomment-667248030
It's true that `html/doc/` is under source control. However I'd have under source control in https://github.com/apache/incubator-pagespeed-ngx maybe just as an `INSTALL` at the root pointing.
This way it would only need to be valid for the current commit, then the instructions could be simplified a lot:
```
-nps_dir=$(find . -name "*pagespeed-ngx-${NPS_VERSION}" -type d)
+nps_dir=incubator-pagespeed-ngx-${NPS_VERSION}
cd "$nps_dir"
-NPS_RELEASE_NUMBER=${NPS_VERSION/beta/}
-NPS_RELEASE_NUMBER=${NPS_VERSION/stable/}
-psol_url=https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz
-[ -e scripts/format_binary_url.sh ] && psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
+psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] wernight edited a comment on pull request #2021: Update build_ngx_pagespeed_from_source.html
Posted by GitBox <gi...@apache.org>.
wernight edited a comment on pull request #2021:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2021#issuecomment-667248030
It's true that `html/doc/` is under source control. I think I was looking at an older version. Maybe just have an `INSTALL` at the root pointing to `html/doc/` directory (not the URL).
Supposing that the current `html/doc/` only needs to be valid for the current commit, then why not remote a lot in html/doc/build_ngx_pagespeed_from_source.html?
Things that I'd remove:
```
-nps_dir=$(find . -name "*pagespeed-ngx-${NPS_VERSION}" -type d)
+nps_dir=incubator-pagespeed-ngx-${NPS_VERSION}
cd "$nps_dir"
-NPS_RELEASE_NUMBER=${NPS_VERSION/beta/}
-NPS_RELEASE_NUMBER=${NPS_VERSION/stable/}
-psol_url=https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz
-[ -e scripts/format_binary_url.sh ] && psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
+psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] wernight edited a comment on pull request #2021: Update build_ngx_pagespeed_from_source.html
Posted by GitBox <gi...@apache.org>.
wernight edited a comment on pull request #2021:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2021#issuecomment-667248030
It's true that `html/doc/build_ngx_pagespeed_from_source.html` is under source control. However I'd have under source control in https://github.com/apache/incubator-pagespeed-ngx maybe just as an `INSTALL` at the root pointing.
This way it would only need to be valid for the current commit, then the instructions could be simplified a lot:
```
-nps_dir=$(find . -name "*pagespeed-ngx-${NPS_VERSION}" -type d)
+nps_dir=incubator-pagespeed-ngx-${NPS_VERSION}
cd "$nps_dir"
-NPS_RELEASE_NUMBER=${NPS_VERSION/beta/}
-NPS_RELEASE_NUMBER=${NPS_VERSION/stable/}
-psol_url=https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz
-[ -e scripts/format_binary_url.sh ] && psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
+psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] wernight commented on pull request #2021: Update build_ngx_pagespeed_from_source.html
Posted by GitBox <gi...@apache.org>.
wernight commented on pull request #2021:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2021#issuecomment-667248030
It's true that `html/doc/` is under source control. I think I was looking at an older version. Maybe just have an `INSTALL` at the root pointing to `html/doc/` directory (not the URL).
Supposing that the current `html/doc/` only needs to be valid for the current commit, then why not remote a lot in html/doc/build_ngx_pagespeed_from_source.html?
Things that I'd remove: (see PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org