Re: [PR] [FLINK-40847][Connectors/Kafka] Include transaction naming strategy in sink equality [flink-connector-kafka]

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on code in PR #330:
URL: https://github.com/apache/flink-connector-kafka/pull/330#discussion_r4159218191


##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java:
##########
@@ -832,6 +832,19 @@ void testTableSinkStrategyTranslation() {
                             "kafka-sink",
                             namingStrategy);
             assertThat(actualSink).isEqualTo(expectedSink);
+            final DynamicTableSink copiedSink = actualSink.copy();
+            assertThat(copiedSink).isEqualTo(actualSink);
+            assertThat(copiedSink.hashCode()).isEqualTo(actualSink.hashCode());

Review Comment:
   ```suggestion
               assertThat(copiedSink).hasSameHashCodeAs(actualSink);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org