You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/02/01 05:36:15 UTC
[GitHub] couchdb-fauxton pull request: Updates to PerPageSelector component
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/635
Updates to PerPageSelector component
This makes a couple of small updates to the PerPageSelector
component to allow for a custom list of options, and a custom
label.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton per-page-component
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/635.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #635
----
commit 7d0a859324d8d1d56c7c2ad37d667f1597f404c8
Author: Ben Keen <be...@gmail.com>
Date: 2016-02-01T04:35:17Z
Updates to PerPageSelector component
This makes a couple of small updates to the PerPageSelector
component to allow for a custom list of options, and a custom
label.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Updates to PerPageSelector component
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/635#discussion_r51451101
--- Diff: app/addons/documents/pagination/tests/pagination.componentSpec.react.jsx ---
@@ -53,6 +53,35 @@ define([
assert.ok(perPageChange.calledWith(perPage));
});
+
+ it('applies custom label', function () {
+ var customLabel = 'alphabet soup';
--- End diff --
:laughing:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Updates to PerPageSelector component
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Updates to PerPageSelector component
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/635#issuecomment-178088800
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---