You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2009/09/17 20:10:49 UTC
svn commit: r816318 - /httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
Author: wrowe
Date: Thu Sep 17 18:10:49 2009
New Revision: 816318
URL: http://svn.apache.org/viewvc?rev=816318&view=rev
Log:
Add the new HAVE_SYS_STAT_H entry
Modified:
httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
Modified: httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in?rev=816318&r1=816317&r2=816318&view=diff
==============================================================================
--- httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in (original)
+++ httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in Thu Sep 17 18:10:49 2009
@@ -18,3 +18,7 @@
/* Define to 1 if `msg_control' is member of `struct msghdr'. */
#undef HAVE_STRUCT_MSGHDR_MSG_CONTROL
+/* Define to 1 if you have the `sys/stat.h' header. */
+#undef HAVE_SYS_STAT_H
+
+
Re: svn commit: r816318 - /httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
Posted by Rainer Jung <ra...@kippdata.de>.
On 17.09.2009 20:41, William A. Rowe, Jr. wrote:
> wrowe@apache.org wrote:
>> Author: wrowe
>> Date: Thu Sep 17 18:10:49 2009
>> New Revision: 816318
>>
>> URL: http://svn.apache.org/viewvc?rev=816318&view=rev
>> Log:
>> Add the new HAVE_SYS_STAT_H entry
>
> Before I reroll, Rainer, can you verify this clears up the errors
> you observed?
I added a simple typo fix in r816385 just now. With that the feature
test succeeds and I can compile and run the module.
> You mention Solaris. It is notoriously faulty for demanding headers
> in a specific sequence, almost as bad as Windows. Give this a try
> and if all works out, I think we are ready 0.9.6.
Looks good.
There are a few warnings, but they would need more FMT type macros:
ftp_util.c: In function 'ftp_direntry_make':
ftp_util.c:224: warning: format '%d' expects type 'int', but argument 3
has type 'apr_uid_t'
ftp_util.c:225: warning: format '%d' expects type 'int', but argument 3
has type 'apr_gid_t'
ftp_util.c:231: warning: format '%d' expects type 'int', but argument 3
has type 'apr_uid_t'
ftp_util.c:236: warning: format '%d' expects type 'int', but argument 3
has type 'apr_gid_t'
Unfortunately there are no FMT macros for those types, not are there
apr_psprintf format characters. I guess we can live with it for a beta.
Regards,
Rainer
Re: svn commit: r816318 - /httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Sep 17, 2009, at 3:47 PM, William A. Rowe, Jr. wrote:
> Jim Jagielski wrote:
>>
>> On Sep 17, 2009, at 2:41 PM, William A. Rowe, Jr. wrote:
>>
>>> wrowe@apache.org wrote:
>>>> Author: wrowe
>>>> Date: Thu Sep 17 18:10:49 2009
>>>> New Revision: 816318
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=816318&view=rev
>>>> Log:
>>>> Add the new HAVE_SYS_STAT_H entry
>>>
>>> Before I reroll, Rainer, can you verify this clears up the errors
>>> you observed?
>>
>> Also affects OS X, btw.
>
> If someone on OS X can confirm trunk is behaving there, too, that
> would
> be great :)
>
Should have a test run by tomorrow am.
Re: svn commit: r816318 - /httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Jim Jagielski wrote:
>
> On Sep 17, 2009, at 2:41 PM, William A. Rowe, Jr. wrote:
>
>> wrowe@apache.org wrote:
>>> Author: wrowe
>>> Date: Thu Sep 17 18:10:49 2009
>>> New Revision: 816318
>>>
>>> URL: http://svn.apache.org/viewvc?rev=816318&view=rev
>>> Log:
>>> Add the new HAVE_SYS_STAT_H entry
>>
>> Before I reroll, Rainer, can you verify this clears up the errors
>> you observed?
>
> Also affects OS X, btw.
If someone on OS X can confirm trunk is behaving there, too, that would
be great :)
Re: svn commit: r816318 - /httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Sep 17, 2009, at 2:41 PM, William A. Rowe, Jr. wrote:
> wrowe@apache.org wrote:
>> Author: wrowe
>> Date: Thu Sep 17 18:10:49 2009
>> New Revision: 816318
>>
>> URL: http://svn.apache.org/viewvc?rev=816318&view=rev
>> Log:
>> Add the new HAVE_SYS_STAT_H entry
>
> Before I reroll, Rainer, can you verify this clears up the errors
> you observed?
>
> You mention Solaris. It is notoriously faulty for demanding headers
> in a specific sequence, almost as bad as Windows. Give this a try
> and if all works out, I think we are ready 0.9.6.
>
> The point I raised yesterday is that simple-is-better, and follow the
> existing design pattern ;-)
>
> It sure is a shame that apr never fixed this, perhaps because we had
> figured on assuming sys/stat.h is always present, based on C89 spec?
>
Also affects OS X, btw.
Re: svn commit: r816318 - /httpd/mod_ftp/trunk/modules/ftp/ftp_config.h.in
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
wrowe@apache.org wrote:
> Author: wrowe
> Date: Thu Sep 17 18:10:49 2009
> New Revision: 816318
>
> URL: http://svn.apache.org/viewvc?rev=816318&view=rev
> Log:
> Add the new HAVE_SYS_STAT_H entry
Before I reroll, Rainer, can you verify this clears up the errors
you observed?
You mention Solaris. It is notoriously faulty for demanding headers
in a specific sequence, almost as bad as Windows. Give this a try
and if all works out, I think we are ready 0.9.6.
The point I raised yesterday is that simple-is-better, and follow the
existing design pattern ;-)
It sure is a shame that apr never fixed this, perhaps because we had
figured on assuming sys/stat.h is always present, based on C89 spec?