[GitHub] [hadoop-ozone] elek commented on a change in pull request #262: HDDS-2459. Change the ReplicationManager to consider decommission and maintenance states

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #262: HDDS-2459. Change the ReplicationManager to consider decommission and maintenance states
URL: https://github.com/apache/hadoop-ozone/pull/262#discussion_r351642030
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
 ##########
 @@ -97,6 +98,11 @@
    */
   private final LockManager<ContainerID> lockManager;
 
+  /**
+   * Used to lookup the health of a nodes or the nodes operational state.
+   */
+  private final NodeManager nodeManager;
 
 Review comment:
   As far as I understood the proposal is to update the state of the containers by an other components based on the node state and use only the container state here (instead of checking the state by the node manager).
   
   I discussed it with @anuengineer. Let's go forward with this approach and later we can improve this part.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org